<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100447/">http://git.reviewboard.kde.org/r/100447/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some things I notices when testing
-I'm did not find out on how to create new connections between shapes.
-When clicking on a connection point to select it the options are disabled
Your patch fixes bug 251529
Thorsten</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On January 26th, 2011, 10:48 p.m., Jan Hambrecht wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jan Hambrecht.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2011, 10:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch properly implements support for odf glue points (=connection points in flake) as defined in the ODF specification.
The following are some of the main points tackled:
* a new struct KoConnectionPoint which holds the relevant data of a connection point
* some new API in KoShape to handle connection points
* loading of custom connection points and their attributes like escape direction and align
* saving of connection points
* huge improvement to the connection tool which now can also create, delete and edit connection points
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the document attached to the bug report as well as with documents created with LibreOffice.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=251529">251529</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/shapes/relationdesign/kexirelationdesignshape.cpp <span style="color: grey">(27604d4)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(0447004)</span></li>
<li>libs/flake/KoConnectionPoint.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoConnectionPoint.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoConnectionShape.h <span style="color: grey">(862d41b)</span></li>
<li>libs/flake/KoConnectionShape.cpp <span style="color: grey">(8430eb0)</span></li>
<li>libs/flake/KoConnectionShapeLoadingUpdater.cpp <span style="color: grey">(0bd834c)</span></li>
<li>libs/flake/KoConnectionShape_p.h <span style="color: grey">(ea3b0ba)</span></li>
<li>libs/flake/KoOdfWorkaround.h <span style="color: grey">(e6a5c63)</span></li>
<li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(36fd86b)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(f7179d7)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(c5aee86)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(f52ba8c)</span></li>
<li>libs/flake/KoTextOnShapeContainer.cpp <span style="color: grey">(07921ca)</span></li>
<li>libs/flake/tools/KoParameterChangeStrategy.h <span style="color: grey">(a10e54f)</span></li>
<li>libs/flake/tools/KoParameterChangeStrategy.cpp <span style="color: grey">(925602f)</span></li>
<li>libs/flake/tools/KoParameterChangeStrategy_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/tools/KoPathConnectionPointStrategy.h <span style="color: grey">(2ec9467)</span></li>
<li>libs/flake/tools/KoPathConnectionPointStrategy.cpp <span style="color: grey">(15764bc)</span></li>
<li>libs/flake/tools/KoPathConnectionPointStrategy_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/tools/KoPathTool.h <span style="color: grey">(c863f11)</span></li>
<li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(fe9351a)</span></li>
<li>plugins/defaultTools/CMakeLists.txt <span style="color: grey">(7bd62ce)</span></li>
<li>plugins/defaultTools/connectionTool/AddConnectionPointCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/AddConnectionPointCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ChangeConnectionPointCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ChangeConnectionPointCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionPointWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionPointWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionPointWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.h <span style="color: grey">(c0af323)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.cpp <span style="color: grey">(a25b0d7)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionToolWidget.h <span style="color: grey">(17e072e)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionToolWidget.cpp <span style="color: grey">(d7211ad)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionToolWidget.ui <span style="color: grey">(6249ba4)</span></li>
<li>plugins/defaultTools/connectionTool/MoveConnectionPointStrategy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/MoveConnectionPointStrategy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/RemoveConnectionPointCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/RemoveConnectionPointCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/CMakeLists.txt <span style="color: grey">(c64a256)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-all.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-down.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-horizontal.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-left.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-right.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-up.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-vertical.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/treeshape/Layout.cpp <span style="color: grey">(3b1a7ea)</span></li>
<li>plugins/treeshape/TreeShapeMoveStrategy.cpp <span style="color: grey">(cf20400)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100447/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>