<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100442/">http://git.reviewboard.kde.org/r/100442/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Casper</p>
<br />
<p>On January 25th, 2011, 2:04 p.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Casper Boemann.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2011, 2:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch moves KWAnchorStrategy into text shape.
The reason is that it is not possible to do advanced shape anchor logic outside Layout.cpp.
The main idea is to register the shapes into Layout.cpp and layout handles all the necessary things.
The registration is done in KWTextDocumentLayout::positionInlineObject where all the words dependent data are set. (pageRectangle,pageContentRectangle,pageNumber)
If the document or anchored shape changes KoTextDocumentLayout::resetInlineObject is called which resets all the shapes that are not valid and layout finds the right place for them.
Any comments are welcome
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShape.h <span style="color: grey">(f7179d7)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(c5aee86)</span></li>
<li>libs/kotext/KoTextAnchor.h <span style="color: grey">(2bbbf9a)</span></li>
<li>libs/kotext/KoTextAnchor.cpp <span style="color: grey">(ece23d6)</span></li>
<li>libs/kotext/KoTextDocumentLayout.h <span style="color: grey">(4284d37)</span></li>
<li>libs/kotext/KoTextDocumentLayout.cpp <span style="color: grey">(6b66e0f)</span></li>
<li>libs/kotext/KoTextShapeContainerModel.h <span style="color: grey">(ce3a6ae)</span></li>
<li>libs/kotext/KoTextShapeContainerModel.cpp <span style="color: grey">(00ca9b5)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(a23ecc3)</span></li>
<li>plugins/textshape/Layout.h <span style="color: grey">(5e42b7a)</span></li>
<li>plugins/textshape/Layout.cpp <span style="color: grey">(e1228e4)</span></li>
<li>plugins/textshape/TextAnchorStrategy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/TextAnchorStrategy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(2d5c667)</span></li>
<li>words/part/frames/KWAnchorStrategy.h <span style="color: grey">(b39f377)</span></li>
<li>words/part/frames/KWAnchorStrategy.cpp <span style="color: grey">(c168962)</span></li>
<li>words/part/frames/KWTextDocumentLayout.h <span style="color: grey">(59add4f)</span></li>
<li>words/part/frames/KWTextDocumentLayout.cpp <span style="color: grey">(15a8803)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100442/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>