<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100406/">http://git.reviewboard.kde.org/r/100406/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks like it is going in the right direction. However:
* I think KoConfigurationDialog should not add itself any configuration widget, they should instead be added by KoView::showConfigurationDialog, that way the dialog can be reused by non-koview applications
* also, for each page, I would inherit from KoConfigurationDialogPage, instead of creating the UI form inside KoView::showConfigurationDialog and View::addCustomConfigurationDialogPages</pre>
<br />
<p>- Cyrille</p>
<br />
<p>On January 17th, 2011, 1:10 p.m., Shantanu Tushar Jha wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Shantanu Tushar Jha.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2011, 1:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently there is no standard way to add configuration options that can apply calligra-wide to all applications. An example can be the auto-save delay, or default language.
This patch adds the common configuration dialog to libs/main/. If I am proceeding in the right direction, I will change tables to use this system, and update this patch so it can then be merged.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A sample in tables/part/view.cpp shows that this works as expected. By compiling and running this, we see two "Configure Tables" options in calligratables, the new one is the second one. Upon selecting that, a dialog appears with the common "Open/Save" page from libs/main/dialogs/ and a custom page added from Tables.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/CMakeLists.txt <span style="color: grey">(457de07)</span></li>
<li>libs/main/KoConfigurationDialogPage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoConfigurationDialogPage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoView.h <span style="color: grey">(7dfb232)</span></li>
<li>libs/main/KoView.cpp <span style="color: grey">(b09603d)</span></li>
<li>libs/main/dialogs/KoConfigurationDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/dialogs/KoConfigurationDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/dialogs/KoOpenSaveConfigurationWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>tables/part/View.h <span style="color: grey">(a542637)</span></li>
<li>tables/part/View.cpp <span style="color: grey">(8b9ba78)</span></li>
<li>tables/tables.rc <span style="color: grey">(0fde1b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100406/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100406/s/48/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/17/snapshot1_400x100.png" style="border: 1px black solid;" alt="Common Save/Open page" /></a>
<a href="http://git.reviewboard.kde.org/r/100406/s/49/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/17/snapshot2_400x100.png" style="border: 1px black solid;" alt="Custom page added by tables" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>