D16721: Use Krita toolbar in Karbon

[Carl Schwan]

ognarb marked 3 inline comments as done.
ognarb added a comment.


  In D16721#355600 <https://phabricator.kde.org/D16721#355600>, @anthonyfieroni wrote:
  
  > Return QObjects, if you have problems copy linker output here.
  
  
  `make clean` solved the issue

INLINE COMMENTS

> anthonyfieroni wrote in KoToolBoxDocker.cpp:39
> We should know what it is. It used a label instead of KoDockWidgetTitleBar why? Can you revert KoDockWidgetTitleBar, remove this and see how it looks?

I found out that this QLabel is, it's the small draggable zone at the top of the docker. Actual it's still a bit buggy in krita and karbon F6397172: krita_toolbar_to.png <https://phabricator.kde.org/F6397172>. I should fix this before commiting. :D

Edit: It's not a bug, it's a feature :D If I try to center the label, it's look a lot less good looking then not zooming on it. I added a small comment for future reference. :)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20181107/7382a587/attachment.htm>