Review Request 123549: Usability improvements in Kexi CSV import

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123549/#review79784
-----------------------------------------------------------

Ship it!



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp (line 1863)
<https://git.reviewboard.kde.org/r/123549/#comment54646>

    i guess we would break the size of a table schema before running out of uints? :P


- Adam Pigg


On April 28, 2015, 10:11 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123549/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 10:11 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Usability improvements in Kexi CSV import
> 
> - Enable single selection of table cells ("current" cell indicator is not visible in Breeze style)
> CCBUG:344644
> - Display font of edited column names in bold also during editing
> - Allow editing only first row (column names) but also when "First row contains column names" is OFF; this let's the user to fully customize column names before importing
> - Use "Column <n>" column caption and "column_<n>" column name for empty names.
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/importexport/csv/KexiCSVImportDialogModel.h 7a5c1c619f1d215382a13aa5e2ee8663e7eb3bf8 
>   kexi/plugins/importexport/csv/KexiCSVImportDialogModel.cpp 1aa19d98fb7a9731749b4df8595f11f471ea6f40 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 4193b4a56f51f9a1d59d02c20eaa786f0f08dc7a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285e172397ad1cbed2e77f05fad920e0d190 
> 
> Diff: https://git.reviewboard.kde.org/r/123549/diff/
> 
> 
> Testing
> -------
> 
> Tested the import with various options and files
> 
> 
> File Attachments
> ----------------
> 
> The dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/9e59ff84-b05c-4083-b179-90977738fcd3__kexi-2.9-csv-import.png
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150502/b433fe02/attachment.htm>