Review Request: remove use of non-existing icon "duplicate" in Braindump

Friedrich W. H. Kossebau kossebau at kde.org
Sun Jul 22 19:00:33 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105672/
-----------------------------------------------------------

Review request for Calligra and Cyrille Berger Skott.


Description
-------

There is no icon "duplicate" in the icons from the Oxygen set or installed by Calligra.
And e.g. Karbon also does not set an icon for the menu entry "Duplicate".

So for now a proper fix might be to just use no icon in Braindump as well, if only for consistency.

Should a TODO item be added, or okay with no icon here? (should be used in Karbon and possibly elsewhere as well)

Okay to backport to 2.5?


Diffs
-----

  braindump/src/View.cpp 4356654 

Diff: http://git.reviewboard.kde.org/r/105672/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120722/3bdd0acd/attachment.htm>


More information about the calligra-devel mailing list