Review Request: fix iconname of Flow runtime to an existing icon

Yue Liu opuspace at gmail.com
Sun Jul 22 10:09:59 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105654/#review16196
-----------------------------------------------------------

Ship it!


Ship It!

- Yue Liu


On July 22, 2012, 1:09 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105654/
> -----------------------------------------------------------
> 
> (Updated July 22, 2012, 1:09 a.m.)
> 
> 
> Review request for Calligra and Yue Liu.
> 
> 
> Description
> -------
> 
> Currently there is no app icon installed at all for Calligra Flow. The desktop files set the iconname to "kivio", which is existing in the Oxygen icon set. But the AboutData of Flow sets the iconname indirectly to "flow", for which no icon exists at all.
> 
> Attached patch fixes this by setting the iconname for AboutData to "kivio" as well. (As a temporary solution, until there is an Flow app icon).
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   flow/part/FlowAboutData.h 4e301e9 
> 
> Diff: http://git.reviewboard.kde.org/r/105654/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120722/520ec7db/attachment.htm>


More information about the calligra-devel mailing list