Review Request: make it possible to read properties from different property types.

[Jan Hambrecht]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102737/#review6997
-----------------------------------------------------------

Ship it!


I think beside the two things pointed out you could commit.


libs/odf/KoStyleStack.cpp
<http://git.reviewboard.kde.org/r/102737/#comment6177>

    I think beside checking for a null pointer a check for an empty string would be good too.



libs/odf/KoStyleStack.cpp
<http://git.reviewboard.kde.org/r/102737/#comment6176>

    I think it would be good to check for an empty string here.


- Jan Hambrecht


On Sept. 29, 2011, 1:28 p.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102737/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 1:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Make it possible to load style properties from multiple properties.
> 
> For embedded text shapes paragraph style properties can be saved in style:paragraph-properties or in graphic:paragraph-properties. 
> It is also possible that some values are in one and others are in the other e.g. in parent styles. 
> 
> This patch add the possibilty to load the properties from more then one property type.
> 
> This partly fixes the bug in the bug report attached. It is not fully fixed as not all properties are used by the text shape yet.
> 
> 
> This addresses bug 282617.
>     http://bugs.kde.org/show_bug.cgi?id=282617
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoParagraphStyle.cpp 9ecd77a 
>   libs/odf/KoStyleStack.h a087dc3 
>   libs/odf/KoStyleStack.cpp d94025a 
> 
> Diff: http://git.reviewboard.kde.org/r/102737/diff/diff
> 
> 
> Testing
> -------
> 
> Run with cstester and found some nice improvements.
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111002/760cb6ef/attachment.htm>