Review Request: some small performance improvements in plugins

[Sebastian Sauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101736/#review4110
-----------------------------------------------------------

Ship it!


Looks good .Thanks!

- Sebastian


On June 23, 2011, 7:33 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101736/
> -----------------------------------------------------------
> 
> (Updated June 23, 2011, 7:33 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> prefix ++ for non trivial types and some reference paramenters instead of value parameters.
> 
> 
> Diffs
> -----
> 
>   plugins/chartshape/kdchart/src/KDChartDataValueAttributes.h 99edb3a 
>   plugins/chartshape/kdchart/src/KDChartDataValueAttributes.cpp a51653d 
>   plugins/pluginshape/PluginShape.cpp 5ca4797 
>   plugins/textediting/spellcheck/BgSpellCheck.cpp f78b175 
>   plugins/textshape/commands/AcceptChangeCommand.cpp d191859 
>   plugins/textshape/commands/RejectChangeCommand.cpp e9a1475 
>   plugins/textshape/dialogs/FontDia.cpp 1c68ea8 
>   plugins/vectorshape/VectorShape.cpp 328c182 
> 
> Diff: http://git.reviewboard.kde.org/r/101736/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110623/481cf325/attachment.htm>