Review Request: Change KoImageSelectionWidget to no longer embed a KFileWidget

Marijn Kruisselbrink m.kruisselbrink at student.tue.nl
Tue Feb 22 15:56:50 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100716/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

This changes KoImageSelectionWidget to no longer be a widget that embeds a KFileWidget, but instead show a KFileDialog to select a file. This should make it for example feel more native when run on windows, as you get a real file dialog. The overall behavior of the widget hasn't really changed with this diff, after selecting a file in the dialog/widget, you still get a preview of the image and can Ok/Cancel it.


Diffs
-----

  libs/main/KoImageSelectionWidget.h 737ffdc3f655eaffb31eeb569384fe2b6c8aa678 
  libs/main/KoImageSelectionWidget.cpp 92c6d215b1a4c30607b1855dd517cfbce61bdda7 

Diff: http://git.reviewboard.kde.org/r/100716/diff


Testing
-------


Thanks,

Marijn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110222/8ab1878b/attachment.htm>


More information about the calligra-devel mailing list