Review Request: GSoC, Stage: Add a tabbar to switch between view modes

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102198/#review5462
-----------------------------------------------------------


Hello Paul,

sorry that it took so long until I tested it.

I like the look of it.

There is one thing that needs to be fixed so it can work perfectly. The same tabbar needs to be used in all view modes. See my inline comments on how to do it. If you see any problems please let me know and we can figure out a way to fix it.

One additional thing I thought might be good to have is a way to configure the tabbar to be on the left of the canvas. With todays screens (16:9) that will give more space However that is something for later.

Thorsten




kpresenter/part/KPrView.cpp
<http://git.reviewboard.kde.org/r/102198/#comment4902>

    I think it would be a good idea to set that information via the view mode or get the tab names from the view mode. If we then also can do that in a loop over the viewmodes it would be working without any additional change when a new viewmode is added.
    
    Text that gets added needs a i18n method call around it.



kpresenter/part/KPrView.cpp
<http://git.reviewboard.kde.org/r/102198/#comment4901>

    Please use a switch statement here. The default just needs to break.



kpresenter/part/KPrViewModeSlidesSorter.h
<http://git.reviewboard.kde.org/r/102198/#comment4903>

    It should be avoided to have the tabbar in the slide sorter again. It should use the same tabbar as the other viewmodes. This will avoid the flickering which can be seen now in the tab bar when switching to the slide sorter. It will also avoid all the code duplication needed.
    



libs/kopageapp/KoPAView.h
<http://git.reviewboard.kde.org/r/102198/#comment4904>

    Please move the variable to the KoPAView::Private.



libs/kopageapp/KoPAView.cpp
<http://git.reviewboard.kde.org/r/102198/#comment4905>

    I thing you need to move the tab bar to be outside this grid so it is possible to use it in all view modes.


- Thorsten


On Aug. 3, 2011, 4:44 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102198/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2011, 4:44 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add a tabbar to Stage on top of views, to switch between normal, notes and slides sorter view.
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrView.h 8c9d46158171b38363fdd9e716f4ab3d3b193200 
>   kpresenter/part/KPrView.cpp fb34504c8143c6cfd7cf5e6c11908897fa99cce9 
>   kpresenter/part/KPrViewModeSlidesSorter.h 8f0307ff8ccc922872cbcb589daea49d5b627270 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp 9941f4bbde74d4cc3566eecdf314815876c482ab 
>   libs/kopageapp/KoPAView.h ee9b7950cebad23b2303bbce72e5164e4f42e1e5 
>   libs/kopageapp/KoPAView.cpp db61b647477194f062afd4f4f6ef9b6010b2f9a9 
> 
> Diff: http://git.reviewboard.kde.org/r/102198/diff
> 
> 
> Testing
> -------
> 
> build and run
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110807/e27c5126/attachment.htm>