<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121450/">https://git.reviewboard.kde.org/r/121450/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You rock! All looks great to me!</p></pre>
<br />
<p>- Andrew Lake</p>
<br />
<p>On December 11th, 2014, 3:35 p.m. UTC, Eshton Robateau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Bangarang.</div>
<div>By Eshton Robateau.</div>
<p style="color: grey;"><i>Updated Dec. 11, 2014, 3:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bangarang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The basic listengine architecture and necessary classes have been ported. The are a few stubs for local storage and metadata handling. Dependencies updated for phonon, at present KF5 is incompatible with phonon4, so we have to build explicitly against phonon4qt5. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://quickgit.kde.org/?p=clones%2Fbangarang%2Ferobateau%2Fmybangarang.git&a=commit&h=75cffc44f3253d5ebdac15654e53b271bfe3f413</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No unit tests in place, no serious warnings (insignificant Wunused-parameter reminders) in builds. </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6400e43)</span></li>
<li>cmake/FindLibraryWithDebug.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/FindTaglib.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(bbe2b31)</span></li>
<li>src/app/main.cpp <span style="color: grey">(92bfe4d)</span></li>
<li>src/platform/devicemanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/devicemanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/downloader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/downloader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/cachelistengine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/cachelistengine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/filelistengine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/filelistengine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/listengine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/listengine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/listenginefactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/listenginefactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/medialistsengine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/medialistsengine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/savedlistsengine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/listengines/savedlistsengine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/mediaitemmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/mediaitemmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/medialistcache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/medialistcache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/artwork.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/artwork.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/filetags.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/filetags.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/general.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/general.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/mediaitems.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/mediaitems.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/sha256.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/sha256.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/thread.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/thread.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/typechecks.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/typechecks.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/utilities.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121450/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>