<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" content="1" /><style type="text/css">p, li { white-space: pre-wrap; }</style></head><body style=" font-family:'Segoe'; font-size:10pt; font-weight:400; font-style:normal;">Am Saturday 10 January 2009 schrieben Sie:<br>
> Hi Thomas,<br>
Hi Nikolaj (you get the mail twice to avoid list approval delay... ;-)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>> Thanks for the patch. I just added all this new playlist code from a<br>
> personal git branch the other day, so I am well aware that it needs a<br>
> lot of polish still! :-)<br>
actually i've found some more issues - partially from my patch :-(<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>... see new patch =D<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>1) the model values were escaped from the playlist model<br>
----<br>
...leading to &s; etc. in the playlist<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>maybe it would be better to pass the plain version from the model and escape <br>
it on demand? (i.e. if the view uses richtext painting - afaics currently none <br>
does?)<br>
otherwise we'd need to QString::replace() every playlist entry after just <br>
uselessy escaping it :-(<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>2) (fallen out) there was an issue with empty etries (e.g. i tried to embrace <br>
the album, leading to an opening brace but no closing one and no dummy <br>
content)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>leading to<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>3) there's no dummy ("unknown") content if the metafield is empty, what <br>
(though a good idea in general) can lead to dull output like<br>
" by on "<album> ... ;-P<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>i therefore extended the elements by two attributes "prefix" and "suffix" to <br>
be able to bind synthetic text to specific metainfo and removed the "value" <br>
string handling (which was incoherent anyway)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>4) i tried a better handling for right aligned elements (kinda bidi rendering) <br>
when using autosizes (before, everything is ditched to the right border)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>5) the casual padding extension was afaics useless (you can add the padding <br>
anyway - it's just not gonna used for the last element at all...)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>more TODO:<br>
==========<br>
- if you accept the below patch, the "Title (with Track number) attribute can <br>
probably be removed (e.g. i currently use a dot)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>- the tracknumber should be "offsettable" (i.e. check max numbers in album and <br>
prefix a "0" - for a simple life, we could just use %2d anyway, assuming that <br>
most albums will have 10 - 99 tracks, esp. as afair 99 is a cdda limit...)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>- we should hide out for a way to inject the album length for the "length" <br>
attribute in headers<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>- the last used layout should be stored and reused on quit/restart<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>- the xml file should be reparsed on layout changes (currently i had to <br>
restart amarok everytime i changed the least bit in the config file)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>> If you are interested, you are more than welcome to help improving it<br>
> and making sure that Amarok 2.1.0 gets the coolest playlist of any<br>
> player out there. The major task that needs doing is coming up with a<br>
> simple and intuitive interface for letting users configure elements<br>
kwrite ;-P<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>ok, for the weak and unskilled: i guess you've seen the new kmail listview <br>
(actually i thought amarok and kmail were gonna rely on the same lib)<br>
it already has a nice configurator. maybe you can just dump that code and use <br>
amarok specific items? (at least the result is very similar but i don't know <br>
if it manages ann xml structure as well - KDE could really need such class <br>
however)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>> Also, do you have an example layout using some of the new features (<br>
> auto sizing and custom strings ) that your patch added? If so, could<br>
> you please send a patch with that?<br>
attached (in addition to the patch)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>> usually catch me on IRC channel #amarok on irc.freenode.net . My nick<br>
> is nhnFreespirit. I will most likely be away most of today though.<br>
me == unreasonable internet connection (for teh rest of this month - <br>
hopefully) == nix IRC ;-)<br>
i'll contact you there /iff/ i enter this century before we did the <br>
playlist...<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>Thomas<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p><p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p><p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p></body></html>