<br><br><div><span class="gmail_quote">On 01 Jan 2008 20:40:18 +0000, <b class="gmail_sendername">N.C. Wilson</b> <<a href="mailto:ncw33@cam.ac.uk" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
ncw33@cam.ac.uk</a>> wrote:</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
Hello everyone. I have just been trying out amarok 2 over the last few<br>days, and it is great! I did however do a bit of poking around and tried a<br>few new ideas (patch attached).<br><br>Changes:<br><br>1. The "Group by" box in the collection browser did not remember settings
<br>when exiting.</blockquote><div><br></div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
2. I did a bit of general fiddling with the collection view. You can now<br>get rid of the annoying track numbers and sort by any combination of<br>fields</blockquote><div><br><br>Just an FYI, it is not good to save the return value of Amarok::config (IIRC, due to threading isues). So the first "fix" doesn't really work :)
<br>Otherwise, this patch looks good.<br></div><br><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
3. I noticed as I was doing this that the config dialogues are a little<br>scrappy (inconsistent caps, indentation, etc) so I did a bit of neatening<br>while I was there (also ported a few old Qt3 classes just for neatness).
</blockquote><div><br>these are all useful changes, and i can't see any reduction in functionality. </div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
4. Fixed some odds and ends in the config boxes (greying out boxes at the<br>right time etc.) Also fixed a bug with the code for opening the config box<br>to a specified page.</blockquote><div><br>i'll be honest, i can't really see the difference with the greying out. i tried checking and unchecking stuff, but it seemed pretty logical before and after. but the patch doesn't mess anything up...2
</div><br>the specified page fix looks good too.<br> <br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
5. Added some little features for altering the sort order. Old order would<br>have been eg.:<br> - Symphony 1<br> - Symphony 10<br> - Symphony 2<br>Now the three are shown correctly in order.</blockquote><div><br> you definitely need to comment your code here. CollectionSortFilterProxyModel::lessThanString needs some doc lovin'
<br>to bo honest a relatively quick readthrough shows me that it would take me quite a significant amount of time to parse the code, so i'm going to wait for some comments.<br></div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
6. I also made a customisable thing for ignoring prefixes on entries. (I<br>find this very neat - give it a whirl and you'll see what I mean! Putting<br>QRegExp support into everything is dead easy too if it would be useful.)
<br>This is primarily useful for French or German names, where you want "von<br>Richthofen" to appear under R, but still display as "von Richthofen", not<br>"Richthofen, von" or something stupid like that.
</blockquote><div><br>i don't like how there is now a new config pane. IMHO we need to cut down on options wherever possible, and to be honest i think 99% of users does not care about custom prefix settings. we can easily specify a default that will work for virtually everyone and save it in a config file, users that really need to remove <insert 'the' in random language here> as a prefix can manually edit that.
<br><br>what i think may be a better place for the "select how to sort by" options is this: maybe under Group By in the collectionbrowser the last entry could be "custom", which opens a small dialog (with just the customizable settings). this would remove the need for the config pane completely (the one checkbox could go in the Collection pane).
<br><br>anyway, thats my opinion :)<br></div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
7. Probably a few other little one-liners.<br><br>I noticed that in the code there was a commented out line saying that<br>showing "Artist / Year - Album" was far harder than "Artist / Year /<br>Album". The only way I could think of fixing this would be to get rid of
<br>the idea of Meta::Album and Meta::AlbumPtr items, and instead have some<br>sort of a Meta::Field and Meta::FieldPtr class which can hold a custom<br>field, constucted with a regex from the tag fields in Collection Manager.
<br>This seems quite a large change, so I assume it is not something people<br>want done? Being able to completely control the presentation would be nice,<br>but probably not worth it (laying out your collection by customised fields
<br>with regexes would be very cool though, especially for people like me with<br>hundreds of GBs of music).</blockquote><div><br> </div><br><div>you're going to have to talk to maxx_k about this, the Meta:: stuff is his. but i'm going to side with maxx_k simply because the architecture is new from the ground-up and (i believe) designed to be simple and extensible... and last us a long time. a Meta::Field constructed from a regex from the tags in collection manager is far from simple.
<br><br>either way, maxx_k is the authority on this stuff, unfortunately he is out of irc/coding for a while, but should check amarok-devel@ (i'm cc'ing the devel list).<br><br><br> </div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
Also, am I right in guessing that the huge blank holes in places like the<br>Meta::Capability stuff are just because they have not been implemented yet? <br>It would be nice to get the tagger and organiser back running.</blockquote>
<div><br>yeah, chances are that is the issue. once again, maxx_k's domain though, so he can give you a better answer. </div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
Anyway, I am very pleased to see how nice the new version is looking. Well<br>done to all! I would love to help as much as possible, but term starts next <br>week to I suspect I will not have any time.</blockquote><div> </div>
<br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
Nicholas<br>_______________________________________________<br>Amarok mailing list<br><a href="mailto:Amarok@kde.org" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">Amarok@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/amarok" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
https://mail.kde.org/mailman/listinfo/amarok</a><br><br><br></blockquote></div><br><br clear="all"><br>-- <br>______________________________________________________<br>Leo Franchi <br>4305 Charlemagne Ct
<a href="mailto:lfranchi@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">lfranchi@gmail.com</a> <br>Austin cell: (650) 704 3680<br>TX, USA home: (650) 329 0125