[PATCH] Enable playing of last.fm's tag stations

[Trever Fischer]

On Monday 08 December 2008 02:20:01 am you wrote:
> Hi Trevor
>
> I just tested your patch, and it works great. There are a few minor
> style nitpicks, but nothing major.
>
> My main concern is that I really don't like the interface. In my
> opinion it is  counter intuitive that the "go" button is also the
> selector. Also, there is no way to tell what pressing "go" will
> actually do without consulting the drop down list ( how do you know
> what the default is when you just started Amarok? )
Thats what I thought too. Also, the user can see the default by the clickText 
in the textbox. If it is set to 'artist', it shows "Enter artist". If its a 
tag, it says "Enter music tag".
>
> A better approach, I think, would be to have the drop-down box as a
> separate element so you have "dropdown - text-edit - go-button". They
> you would always be able to see what the current "mode" is.
Thats a but cluttered so I didn't want to put it in right away. An alternate 
solution would be to change the Go button's icon to a picture of an artist, 
tag, group, etc.
>
> We do have plans to rework the Last.fm service somewhat, and it would
> be great if you would like to help with this. Overall your patch is a
> great start ( and something we have thought about doing for a long
> time ) but the interface for it needs to be a bit clearer.
I'd love to, but I'm more or less unavailable right now. Its finals week here 
at my university, and as soon as I'm done I'm going back to helping PolicyKit-
KDE and KPackageKit get into KDE 4.3 beta.

> I hope you take this as constructive criticism and I hope to see an
> updated patch from you soon! If you want to discuss this some more,
> feel free to drop by channel #amarok on irc.freenode.net, you can ping
> me there as "nhnFreespirit"
Thanks! Today I only have one exam and then another one over 24 hours later, 
so I'll tinker around with it between studying. I'm usually on there as 
workman161.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/amarok/attachments/20081208/61d1b4f2/attachment.sig>