Amarok vs Gstreamer

Torgil Svensson torgil.svensson at gmail.com
Tue Sep 5 23:14:11 UTC 2006


Gstreamer engine didn't compile because of a recent name-change
(581133) which "forgot" the gst-engine. This patch fixes this. Please
apply.


diff --git a/src/engine/gst10/gstconfigdialog.h
b/src/engine/gst10/gstconfigdialog.h
index 67257ec..c27aa78 100644
--- a/src/engine/gst10/gstconfigdialog.h
+++ b/src/engine/gst10/gstconfigdialog.h
@@ -11,7 +11,7 @@ #include <qobject.h>

 class GstEngine;

-class GstConfigDialog : public amaroK::PluginConfig
+class GstConfigDialog : public Amarok::PluginConfig
 {
     Q_OBJECT


On 9/5/06, Torgil Svensson <torgil.svensson at gmail.com> wrote:
> The easiest way of getting gstreamer engine to work is just reverting
> the commit that disabled it, which is 556594, i've done it in one of
> the attached files.
>
> It's been a while since I've compiled amarok but the patches applies
> fine to the current trunk (581199) and there's been no changes since
> last time that suggests that it shouldn't work. I can't see any
> "code-changes" since gstreamer was disabled in June (just diff 581199
> against 556594 on folder "src/engine/gst10/" and see for yourself).
> But as Paul says, it works!
>
> //Torgil
>
>
> On 9/5/06, paulc2 at optonline.net <paulc2 at optonline.net> wrote:
> > (1) you need to modify these files:
> >
> > - amarok/configure.in.in
> > - amarok/configure.in.bot
> > - amarok/src/engine/Makefile.am
> > - amarok/src/engine/gst10/Makefile.am
> >
> > you should be able to figure out what needs to be uncommented.
> >
> > (2) just run it from the command line.
> >
> > BTW, it already works, but there are issues.  The most vexing one I've come
> > across so far is this:
> >
> > on some Gentoo systems (I have this happening on 2 gentoo systems right
> > now, but
> > there are other gentoo users that work fine) everything sets up fine and there
> > are no errors, until you try to set the pipeline to "PLAYING".  That
> > fails. You don't get to the error bus, so all you know is that the
> > state couldn't be
> > changed, and there is no way to obtain any information about what about the
> > pipeline prevents it from changing the state.
> >
> > Now, here's the catch: the same pipeline (minus the equalizer) plays just fine
> > in gst-launch, and the very same code works fine on other distros, Arch being
> > the other one I'm using most often.  (I've tried removing the equalizer from
> > the pipeline in the amarok engine, but same result, so it doesnt seem
> > to be the
> > culprit).
> >
> > ATM, I'm pretty stumped, so if you or anyone on this list has any ideas...
> >
> > Paul
> >
> > Quoting Jonathan Ryshpan <jonrysh at pacbell.net>:
> >
> > > I'm trying to get amarok working again with gstreamer.  It worked fine
> > > till recently, but upgrades to amarok and/or gstreamer-0.10 have broken
> > > it.  So far I've downloaded amarok from the svn archive and built it
> > > successfully using amarok-svn.sh .
> > >
> > > However, I haven't been able to enable gst.  The tests for gst are
> > > commented out of the configuration.in file, and when I remove the
> > > comment markers ("#"s), configure.in is rebuilt with the gst tests
> > > commented out again.  I haven't been able to find the configuration
> > > files that amarok-svn.sh use as input while building configure.in .
> > >
> > > Questions:
> > >
> > > (1) What files are used to control building configure.in ?
> > >
> > > (2) When I get amarok built to use gstreamer, how can I get amarok to
> > > print out its invocation of gst?  Amarok has a lot of debugging
> > > features, but there doesn't seem to be much info on how to use them.
> > >
> > > Many Thanks - jon
> > >
> > > _______________________________________________
> > > Amarok mailing list
> > > Amarok at kde.org
> > > https://mail.kde.org/mailman/listinfo/amarok
> > >
> >
> >
> >
> > ----------------------------------------------------------------
> > This message was sent using IMP, the Internet Messaging Program.
> >
> >
> > _______________________________________________
> > Amarok mailing list
> > Amarok at kde.org
> > https://mail.kde.org/mailman/listinfo/amarok
> >
>
>
>



More information about the Amarok mailing list