<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi Pedro,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 21 Jul 2020 at 11:28, Pedro de Carvalho Gomes <<a href="mailto:pedrogomes81@gmail.com" target="_blank">pedrogomes81@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi all,,<br>
<br>
Here follows a brief update about my work at Amarok scripting engine. I <br>
have ported back Amarok.Lyrics interface, and have been writing my own <br>
QTScript extensions. With that I plan to have previous scripts, such as <br>
Ultimate Lyrics, running over QJSEngine without any modification.<br>
<br>
The port of QTScript extensions is not easy; I have to do it <br>
class-by-class upon usage at the scripts. Therefore I will select few of <br>
the most popular scripts and only port the classes/methods needed by <br>
those. Other scripts and their requirements will be ported upon requests.</blockquote><div><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">As long as you port the built-in scripts that should be enough. You can always contact the authors of the original scripts if they would give a hand, as most scripts are 3rd-party anyway</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Finally, I ask the other member about the revision process. I know we <br>
have shortage of people. Still many merge requests are simply not moving <br>
forward. </blockquote><div><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I know, but unfortunately I can't really help with this, as I am not a developer. </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thus I ask if there's something I can do to speed it up, such <br>
as publish at Phabricator. Or even if I anyone oppose to the policy of <br>
merging without peer approval if no response for more than X weeks.<br></blockquote><div><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Since the switch to Gitlab, Phabricator should not be used anymore for new merge requests, as <a href="https://invent.kde.org/" style="font-family:Arial,Helvetica,sans-serif">https://invent.kde.org/</a> boards should ultimately replace it. Also not all old merge requests are necessarily to be integrated AFAIK, I seem to remember at least one being not exactly up to date with current git master.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I can acknowledge your merge requests if you want though, it will just not really be a code review. If the tests run smoothly and the merges are not likely to break Continuous Integration I think you should go ahead. </div></div><br clear="all"><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards, Myriam</div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div dir="ltr"><div style="text-align:left"><div><div>Pronouns: she/her</div><div>Proud member of the Amarok and KDE Community: </div><div><a href="https://www.kde.org/" target="_blank">https://www.kde.org</a></div><div>Protect your freedom and<span style="font-family:arial,helvetica,sans-serif"> support the work</span> of<span style="font-family:arial,helvetica,sans-serif"> </span><span style="font-family:arial,helvetica,sans-serif">the</span> FSFE:</div><div><a href="http://www.fsfe.org/" style="color:rgb(17,85,204)" target="_blank">https://www.fsfe.org</a></div></div></div></div></div></div></div>