<table><tr><td style="">wbauer added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28284">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28284#inline-171727">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wbauer</span> wrote in <span style="color: #4b4d51; font-weight: bold;">FindMySQLe.cmake:45</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Right, that's exactly what I was referring to in my last comment, and what the openSUSE patch I mentioned (which originally was taken from Arch) is supposed to fix.</p>
<p style="padding: 0; margin: 8px;">I.e. instead of <tt style="background: #ebebeb; font-size: 13px;">set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES})</tt> here, it should do something like this:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">+ find_library(MYSQL_EMBEDDED_LIBRARIES NAMES mysqld libmysqld
+ PATHS
+ $ENV{MYSQL_DIR}/libmysql_r/.libs
+ $ENV{MYSQL_DIR}/lib
+ $ENV{MYSQL_DIR}/lib/mysql
+ PATH_SUFFIXES
+ mysql
+ )</pre></div>
<p style="padding: 0; margin: 8px;">I'm undecided whether this should be done in this patch or rather separately though, as the problem did exist before (so it's actually an unrelated change).</p>
<p style="padding: 0; margin: 8px;">Although, I just noticed that it actually does that below (in line#73ff) if <tt style="background: #ebebeb; font-size: 13px;">(NOT MYSQLE_LIBRARIES)</tt>, so maybe it would just be enough to remove the <tt style="background: #ebebeb; font-size: 13px;">set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES})</tt> here completely?<br />
I'll give that a try...</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">Although, I just noticed that it actually does that below (in line#73ff) if (NOT MYSQLE_LIBRARIES), so maybe it would just be enough to remove the set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES}) here completely?</p></blockquote>
<p style="padding: 0; margin: 8px;">Indeed, it works fine for me (without any additional patch) if I remove that <tt style="background: #ebebeb; font-size: 13px;">set (MYSQLE_LIBRARIES ${MYSQL_LIBRARIES})</tt> line.</p>
<p style="padding: 0; margin: 8px;">As this if branch is empty then (except for the comments, it would probably be more readable to remove the whole branch and invert the <tt style="background: #ebebeb; font-size: 13px;">if</tt> condition.<br />
Actually I think just <tt style="background: #ebebeb; font-size: 13px;">if ("${MC_return_embedded}" STREQUAL "0")</tt> should be enough then, at least that works here on openSUSE too. And probably is more correct as well.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R181 Amarok</div></div></div><br /><div><strong>BRANCH</strong><div><div>mysqle-split-for-phab</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28284">https://phabricator.kde.org/D28284</a></div></div><br /><div><strong>To: </strong>asturmlechner, Amarok, heikobecker, wbauer<br /><strong>Cc: </strong>malteveerman, amarok-devel, vmatare, mdn, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine, nhuisman, paul, domson, yaohanchen, markey, James, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker<br /></div>