<table><tr><td style="">malteveerman updated this revision to Diff 31909.<br />malteveerman added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11968">View Revision</a></tr></table><br /><div><div><p>Added a few random improvements and compilation warning fixes.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R181 Amarok</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D11968?vs=31413&id=31909">https://phabricator.kde.org/D11968?vs=31413&id=31909</a></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11968">https://phabricator.kde.org/D11968</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br />

src/OpmlParser.h<br />

src/OpmlWriter.h<br />

src/amarokurls/BookmarkGroup.cpp<br />

src/amarokurls/BookmarkModel.cpp<br />

src/amarokurls/BookmarkTreeView.cpp<br />

src/browsers/CollectionSortFilterProxyModel.cpp<br />

src/browsers/CollectionSortFilterProxyModel.h<br />

src/browsers/CollectionTreeItemModelBase.cpp<br />

src/browsers/CollectionTreeItemModelBase.h<br />

src/configdialog/ConfigDialog.h<br />

src/configdialog/dialogs/CollectionConfig.h<br />

src/configdialog/dialogs/DatabaseConfig.h<br />

src/configdialog/dialogs/GeneralConfig.h<br />

src/configdialog/dialogs/MetadataConfig.h<br />

src/configdialog/dialogs/NotificationsConfig.h<br />

src/configdialog/dialogs/PlaybackConfig.h<br />

src/configdialog/dialogs/PluginsConfig.h<br />

src/configdialog/dialogs/ScriptsConfig.h<br />

src/context/AmarokContextPackageStructure.h<br />

src/context/AppletModel.h<br />

src/context/ContextView.cpp<br />

src/context/LyricsManager.cpp<br />

src/context/LyricsManager.h<br />

src/context/applets/albums/plugin/AlbumItem.h<br />

src/context/applets/albums/plugin/AlbumsModel.h<br />

src/context/applets/albums/plugin/AlbumsPlugin.cpp<br />

src/context/applets/albums/plugin/TrackItem.h<br />

src/context/applets/analyzer/plugin/AnalyzerBase.cpp<br />

src/context/applets/analyzer/plugin/AnalyzerBase.h<br />

src/context/applets/analyzer/plugin/AnalyzerPlugin.cpp<br />

src/context/applets/analyzer/plugin/BlockAnalyzer.h<br />

src/context/applets/analyzer/plugin/BlockRenderer.h<br />

src/context/applets/analyzer/plugin/BlockWorker.h<br />

src/context/applets/currenttrack/plugin/CurrentPlugin.cpp<br />

src/context/applets/info/plugin/InfoPlugin.cpp<br />

src/context/applets/lyrics/plugin/LyricsEngine.cpp<br />

src/context/applets/lyrics/plugin/LyricsEngine.h<br />

src/context/applets/lyrics/plugin/LyricsPlugin.cpp<br />

src/context/applets/photos/plugin/PhotosPlugin.cpp<br />

src/context/applets/wikipedia/plugin/WikipediaPlugin.cpp<br />

src/context/qml_plugin/src/PixmapItem.h<br />

src/context/qml_plugin/src/Plugin.cpp<br />

src/context/qml_plugin/src/RatingItem.h<br />

src/core-impl/collections/daap/daapreader/Reader.h<br />

src/core-impl/collections/db/sql/SqlMeta.cpp<br />

src/core-impl/collections/db/sql/SqlMeta.h<br />

src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h<br />

src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.h<br />

src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.h<br />

src/core-impl/collections/ipodcollection/jobs/IpodWriteDatabaseJob.h<br />

src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h<br />

src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.cpp<br />

src/core-impl/collections/mtpcollection/handler/MtpHandler.h<br />

src/core-impl/collections/nepomukcollection/NepomukInquirer.h<br />

src/core-impl/collections/playdarcollection/PlaydarCollection.cpp<br />

src/core-impl/collections/support/MemoryQueryMaker.h<br />

src/core-impl/collections/support/jobs/WriteTagsJob.h<br />

src/core-impl/meta/proxy/MetaProxyWorker.h<br />

src/core-impl/meta/timecode/TimecodeMeta.cpp<br />

src/core-impl/playlists/types/file/PlaylistFileLoaderJob.h<br />

src/core/support/Debug_p.h<br />

src/covermanager/CoverFetchQueue.cpp<br />

src/covermanager/CoverFetchQueue.h<br />

src/covermanager/CoverFetcher.cpp<br />

src/covermanager/CoverFetcher.h<br />

src/dialogs/TagDialog.cpp<br />

src/dialogs/TagDialog.h<br />

src/dynamic/BiasSolver.h<br />

src/lyrics/LyricsManager.cpp<br />

src/lyrics/LyricsManager.h<br />

src/musicbrainz/MusicBrainzXmlParser.h<br />

src/musicbrainz/MusicDNSAudioDecoder.h<br />

src/musicbrainz/MusicDNSXmlParser.h<br />

src/playlist/PlaylistController.cpp<br />

src/playlistgenerator/ConstraintSolver.h<br />

src/playlistmanager/PlaylistManager.cpp<br />

src/scanner/AbstractDirectoryWatcher.h<br />

src/scanner/GenericScannerJob.h<br />

src/scripting/scriptengine/AmarokLyricsScript.cpp<br />

src/scripting/scriptengine/AmarokLyricsScript.h<br />

src/scripting/scriptmanager/ScriptItem.cpp<br />

src/scripting/scripts/CMakeLists.txt<br />

src/scripting/scripts/lyrics_lyricwiki/CMakeLists.txt<br />

src/scripting/scripts/lyrics_lyricwiki/main.js<br />

src/scripting/scripts/lyrics_lyricwiki/script.desktop<br />

src/services/ServiceSqlQueryMaker.cpp<br />

src/services/ampache/AmpacheSettings.h<br />

src/services/gpodder/GpodderServiceSettings.h<br />

src/services/jamendo/JamendoXmlParser.h<br />

src/services/magnatune/MagnatuneDatabaseWorker.h<br />

src/services/magnatune/MagnatuneInfoParser.cpp<br />

src/services/magnatune/MagnatuneStore.cpp<br />

src/services/magnatune/MagnatuneXmlParser.h<br />

src/services/mp3tunes/Mp3tunesWorkers.h<br />

src/statsyncing/jobs/MatchTracksJob.h<br />

src/statsyncing/jobs/SynchronizeTracksJob.h<br />

src/widgets/BoxWidget.h<br />

src/widgets/PrettyTreeRoles.h</div></div></div><br /><div><strong>To: </strong>malteveerman, Amarok<br /><strong>Cc: </strong>Amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker<br /></div>