<table><tr><td style="">malteveerman created this revision.<br />malteveerman added a reviewer: Amarok.<br />malteveerman added a project: Amarok.<br />malteveerman requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11862">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Since Qt5Script is deprecated and virtually useless without bindings support I got rid of it.<br />

I moved the lyrics functionality to LyricsManager but the rest I deleted without reimplementing it in C++.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R181 Amarok</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11862">https://phabricator.kde.org/D11862</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

cmake/modules/bindingstest/QtScriptBindingsTest.cpp<br />

src/ActionClasses.cpp<br />

src/App.cpp<br />

src/App.h<br />

src/CMakeLists.txt<br />

src/MainWindow.cpp<br />

src/browsers/CollectionTreeView.cpp<br />

src/browsers/servicebrowser/ServiceBrowser.cpp<br />

src/browsers/servicebrowser/ServiceBrowser.h<br />

src/configdialog/ConfigDialog.cpp<br />

src/configdialog/dialogs/ScriptSelector.cpp<br />

src/configdialog/dialogs/ScriptSelector.h<br />

src/configdialog/dialogs/ScriptsConfig.cpp<br />

src/configdialog/dialogs/ScriptsConfig.h<br />

src/configdialog/dialogs/ScriptsConfig.ui<br />

src/context/LyricsManager.cpp<br />

src/context/LyricsManager.h<br />

src/context/applets/lyrics/plugin/LyricsEngine.cpp<br />

src/context/applets/lyrics/plugin/LyricsEngine.h<br />

src/dialogs/DiagnosticDialog.cpp<br />

src/dialogs/deviceconfiguredialog.cpp<br />

src/dynamic/BiasFactory.cpp<br />

src/lyrics/LyricsManager.cpp<br />

src/lyrics/LyricsManager.h<br />

src/playlistmanager/PlaylistManager.h<br />

src/scripting/scriptconsole/CompletionModel.cpp<br />

src/scripting/scriptconsole/CompletionModel.h<br />

src/scripting/scriptconsole/ScriptConsole.cpp<br />

src/scripting/scriptconsole/ScriptConsole.h<br />

src/scripting/scriptconsole/ScriptConsoleItem.cpp<br />

src/scripting/scriptconsole/ScriptConsoleItem.h<br />

src/scripting/scriptconsole/ScriptEditorDocument.cpp<br />

src/scripting/scriptconsole/ScriptEditorDocument.h<br />

src/scripting/scriptengine/AmarokBookmarkScript.cpp<br />

src/scripting/scriptengine/AmarokBookmarkScript.h<br />

src/scripting/scriptengine/AmarokCollectionScript.cpp<br />

src/scripting/scriptengine/AmarokCollectionScript.h<br />

src/scripting/scriptengine/AmarokCollectionViewScript.cpp<br />

src/scripting/scriptengine/AmarokCollectionViewScript.h<br />

src/scripting/scriptengine/AmarokEngineScript.cpp<br />

src/scripting/scriptengine/AmarokEngineScript.h<br />

src/scripting/scriptengine/AmarokEqualizerScript.cpp<br />

src/scripting/scriptengine/AmarokEqualizerScript.h<br />

src/scripting/scriptengine/AmarokInfoScript.cpp<br />

src/scripting/scriptengine/AmarokInfoScript.h<br />

src/scripting/scriptengine/AmarokKNotifyScript.cpp<br />

src/scripting/scriptengine/AmarokKNotifyScript.h<br />

src/scripting/scriptengine/AmarokLyricsScript.cpp<br />

src/scripting/scriptengine/AmarokLyricsScript.h<br />

src/scripting/scriptengine/AmarokNetworkScript.cpp<br />

src/scripting/scriptengine/AmarokNetworkScript.h<br />

src/scripting/scriptengine/AmarokOSDScript.cpp<br />

src/scripting/scriptengine/AmarokOSDScript.h<br />

src/scripting/scriptengine/AmarokPlaylistManagerScript.cpp<br />

src/scripting/scriptengine/AmarokPlaylistManagerScript.h<br />

src/scripting/scriptengine/AmarokPlaylistScript.cpp<br />

src/scripting/scriptengine/AmarokPlaylistScript.h<br />

src/scripting/scriptengine/AmarokScript.cpp<br />

src/scripting/scriptengine/AmarokScript.h<br />

src/scripting/scriptengine/AmarokScriptConfig.cpp<br />

src/scripting/scriptengine/AmarokScriptConfig.h<br />

src/scripting/scriptengine/AmarokScriptXml.cpp<br />

src/scripting/scriptengine/AmarokScriptXml.h<br />

src/scripting/scriptengine/AmarokScriptableServiceScript.cpp<br />

src/scripting/scriptengine/AmarokScriptableServiceScript.h<br />

src/scripting/scriptengine/AmarokServicePluginManagerScript.cpp<br />

src/scripting/scriptengine/AmarokServicePluginManagerScript.h<br />

src/scripting/scriptengine/AmarokStatusbarScript.cpp<br />

src/scripting/scriptengine/AmarokStatusbarScript.h<br />

src/scripting/scriptengine/AmarokStreamItemScript.cpp<br />

src/scripting/scriptengine/AmarokStreamItemScript.h<br />

src/scripting/scriptengine/AmarokWindowScript.cpp<br />

src/scripting/scriptengine/AmarokWindowScript.h<br />

src/scripting/scriptengine/PHAACG2.py<br />

src/scripting/scriptengine/ScriptImporter.cpp<br />

src/scripting/scriptengine/ScriptImporter.h<br />

src/scripting/scriptengine/ScriptingDefines.cpp<br />

src/scripting/scriptengine/ScriptingDefines.h<br />

src/scripting/scriptengine/exporters/CollectionTypeExporter.cpp<br />

src/scripting/scriptengine/exporters/CollectionTypeExporter.h<br />

src/scripting/scriptengine/exporters/MetaTypeExporter.cpp<br />

src/scripting/scriptengine/exporters/MetaTypeExporter.h<br />

src/scripting/scriptengine/exporters/PlaylistExporter.cpp<br />

src/scripting/scriptengine/exporters/PlaylistExporter.h<br />

src/scripting/scriptengine/exporters/PlaylistProviderExporter.cpp<br />

src/scripting/scriptengine/exporters/PlaylistProviderExporter.h<br />

src/scripting/scriptengine/exporters/QueryMakerExporter.cpp<br />

src/scripting/scriptengine/exporters/QueryMakerExporter.h<br />

src/scripting/scriptengine/exporters/ScriptableBiasExporter.cpp<br />

src/scripting/scriptengine/exporters/ScriptableBiasExporter.h<br />

src/scripting/scriptmanager/ScriptItem.cpp<br />

src/scripting/scriptmanager/ScriptItem.h<br />

src/scripting/scriptmanager/ScriptManager.cpp<br />

src/scripting/scriptmanager/ScriptManager.h<br />

src/scripting/scriptmanager/ScriptUpdater.cpp<br />

src/scripting/scriptmanager/ScriptUpdater.h<br />

src/scripting/scripts/CMakeLists.txt<br />

src/scripting/scripts/ScriptWriting-HOWTO<br />

src/scripting/scripts/librivox_service/CMakeLists.txt<br />

src/scripting/scripts/librivox_service/COPYING<br />

src/scripting/scripts/librivox_service/LibrivoxEmblem.png<br />

src/scripting/scripts/librivox_service/LibrivoxIcon.png<br />

src/scripting/scripts/librivox_service/LibrivoxLogo.png<br />

src/scripting/scripts/librivox_service/LibrivoxScalableEmblem.svgz<br />

src/scripting/scripts/librivox_service/LibrivoxService.html<br />

src/scripting/scripts/librivox_service/README<br />

src/scripting/scripts/librivox_service/audio_book.svgz<br />

src/scripting/scripts/librivox_service/audio_book128.png<br />

src/scripting/scripts/librivox_service/audio_book16.png<br />

src/scripting/scripts/librivox_service/audio_book22.png<br />

src/scripting/scripts/librivox_service/audio_book32.png<br />

src/scripting/scripts/librivox_service/audio_book48.png<br />

src/scripting/scripts/librivox_service/audio_book64.png<br />

src/scripting/scripts/librivox_service/main.js<br />

src/scripting/scripts/librivox_service/script.desktop<br />

src/scripting/scripts/lyrics_lyricwiki/CMakeLists.txt<br />

src/scripting/scripts/lyrics_lyricwiki/main.js<br />

src/scripting/scripts/lyrics_lyricwiki/script.desktop<br />

src/scripting/scripts/qtscript_debug/CMakeLists.txt<br />

src/scripting/scripts/qtscript_debug/debug/debug.js<br />

src/scripting/scripts/qtscript_debug/main.js<br />

src/scripting/scripts/qtscript_debug/script.spec<br />

src/scripting/scripts/radio_station_service/CMakeLists.txt<br />

src/scripting/scripts/radio_station_service/main.js<br />

src/scripting/scripts/radio_station_service/script.desktop<br />

src/scripting/scripts/script_console/CMakeLists.txt<br />

src/scripting/scripts/script_console/main.js<br />

src/scripting/scripts/script_console/script.desktop<br />

src/scripting/scripts/templates/CMakeLists.txt<br />

src/scripting/scripts/templates/script.spec<br />

src/scripting/scripts/templates/template.js<br />

src/scripting/scripts/webcontrol/CMakeLists.txt<br />

src/scripting/scripts/webcontrol/main.js<br />

src/scripting/scripts/webcontrol/script.spec<br />

src/services/scriptable/ScriptableService.cpp<br />

src/services/scriptable/ScriptableService.h<br />

src/services/scriptable/ScriptableServiceCollection.cpp<br />

src/services/scriptable/ScriptableServiceCollection.h<br />

src/services/scriptable/ScriptableServiceCollectionTreeModel.cpp<br />

src/services/scriptable/ScriptableServiceCollectionTreeModel.h<br />

src/services/scriptable/ScriptableServiceInfoParser.cpp<br />

src/services/scriptable/ScriptableServiceInfoParser.h<br />

src/services/scriptable/ScriptableServiceManager.cpp<br />

src/services/scriptable/ScriptableServiceManager.h<br />

src/services/scriptable/ScriptableServiceMeta.cpp<br />

src/services/scriptable/ScriptableServiceMeta.h<br />

src/services/scriptable/ScriptableServiceMeta_p.h<br />

src/services/scriptable/ScriptableServiceQueryMaker.cpp<br />

src/services/scriptable/ScriptableServiceQueryMaker.h<br />

src/services/scriptable/shoutcast_service.rb</div></div></div><br /><div><strong>To: </strong>malteveerman, Amarok<br /><strong>Cc: </strong>Amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker<br /></div>