<table><tr><td style="">malteveerman created this revision.<br />malteveerman added a reviewer: Amarok.<br />malteveerman added a project: Amarok.<br />malteveerman requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10978" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This patch ports the tests and fixes some issues they had. All tests pass now.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R181 Amarok</div></div></div><br /><div><strong>BRANCH</strong><div><div>kf5</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10978" rel="noreferrer">https://phabricator.kde.org/D10978</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
src/importers/itunes/ITunesTrack.cpp<br />
tests/CMakeLists.txt<br />
tests/TestAmarok.cpp<br />
tests/TestCaseConverter.cpp<br />
tests/TestEngineController.cpp<br />
tests/TestExpression.cpp<br />
tests/TestQStringx.cpp<br />
tests/TestSmartPointerList.cpp<br />
tests/TestTagGuesser.cpp<br />
tests/TestTrackOrganizer.cpp<br />
tests/amarokurls/CMakeLists.txt<br />
tests/amarokurls/TestAmarokUrls.cpp<br />
tests/browsers/CMakeLists.txt<br />
tests/browsers/TestSingleCollectionTreeItemModel.cpp<br />
tests/browsers/TestSingleCollectionTreeItemModel.h<br />
tests/context/engines/CMakeLists.txt<br />
tests/context/engines/similarartists/CMakeLists.txt<br />
tests/context/engines/similarartists/TestSimilarArtistsEngine.cpp<br />
tests/context/engines/upcomingevents/CMakeLists.txt<br />
tests/context/engines/upcomingevents/TestUpcomingEventsEngine.cpp<br />
tests/core-impl/collections/aggregate/CMakeLists.txt<br />
tests/core-impl/collections/aggregate/TestAggregateMeta.cpp<br />
tests/core-impl/collections/db/sql/CMakeLists.txt<br />
tests/core-impl/collections/db/sql/TestDatabaseUpdater.cpp<br />
tests/core-impl/collections/db/sql/TestDatabaseUpdater.h<br />
tests/core-impl/collections/db/sql/TestSqlAlbum.cpp<br />
tests/core-impl/collections/db/sql/TestSqlAlbum.h<br />
tests/core-impl/collections/db/sql/TestSqlArtist.cpp<br />
tests/core-impl/collections/db/sql/TestSqlArtist.h<br />
tests/core-impl/collections/db/sql/TestSqlCollection.cpp<br />
tests/core-impl/collections/db/sql/TestSqlCollection.h<br />
tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp<br />
tests/core-impl/collections/db/sql/TestSqlCollectionLocation.h<br />
tests/core-impl/collections/db/sql/TestSqlQueryMaker.cpp<br />
tests/core-impl/collections/db/sql/TestSqlQueryMaker.h<br />
tests/core-impl/collections/db/sql/TestSqlScanManager.cpp<br />
tests/core-impl/collections/db/sql/TestSqlScanManager.h<br />
tests/core-impl/collections/db/sql/TestSqlTrack.cpp<br />
tests/core-impl/collections/db/sql/TestSqlTrack.h<br />
tests/core-impl/collections/support/CMakeLists.txt<br />
tests/core-impl/collections/support/TestArtistHelper.cpp<br />
tests/core-impl/collections/support/TestMemoryQueryMaker.cpp<br />
tests/core-impl/logger/CMakeLists.txt<br />
tests/core-impl/logger/TestProxyLogger.cpp<br />
tests/core-impl/meta/cue/CMakeLists.txt<br />
tests/core-impl/meta/cue/TestCueFileSupport.cpp<br />
tests/core-impl/meta/file/CMakeLists.txt<br />
tests/core-impl/meta/file/TestMetaFileTrack.cpp<br />
tests/core-impl/meta/file/TestMetaFileTrack.h<br />
tests/core-impl/meta/multi/CMakeLists.txt<br />
tests/core-impl/meta/multi/TestMetaMultiTrack.cpp<br />
tests/core-impl/playlists/types/file/CMakeLists.txt<br />
tests/core-impl/playlists/types/file/TestPlaylistFileSupport.cpp<br />
tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp<br />
tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h<br />
tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp<br />
tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.h<br />
tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.cpp<br />
tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.h<br />
tests/core-impl/playlists/types/file/xspf/TestXSPFPlaylist.cpp<br />
tests/core-impl/playlists/types/file/xspf/TestXSPFPlaylist.h<br />
tests/core-impl/support/CMakeLists.txt<br />
tests/core-impl/support/TestTrackLoader.cpp<br />
tests/core/capabilities/CMakeLists.txt<br />
tests/core/capabilities/TestActionsCapability.cpp<br />
tests/core/capabilities/TestActionsCapability.h<br />
tests/core/collections/CMakeLists.txt<br />
tests/core/collections/CollectionLocationTest.cpp<br />
tests/core/collections/TestCollection.cpp<br />
tests/core/collections/TestQueryMaker.cpp<br />
tests/core/collections/TestQueryMaker.h<br />
tests/core/collections/support/CMakeLists.txt<br />
tests/core/collections/support/TestTrackForUrlWorker.cpp<br />
tests/core/interfaces/CMakeLists.txt<br />
tests/core/interfaces/TestMetaCapability.cpp<br />
tests/core/meta/CMakeLists.txt<br />
tests/core/meta/TestMetaTrack.cpp<br />
tests/core/meta/support/CMakeLists.txt<br />
tests/core/meta/support/TestMetaAlbumKey.cpp<br />
tests/core/meta/support/TestMetaConstants.cpp<br />
tests/core/meta/support/TestMetaTrackKey.cpp<br />
tests/core/meta/support/TestPrivateMetaRegistry.cpp<br />
tests/core/playlists/CMakeLists.txt<br />
tests/core/playlists/TestPlaylistFormat.cpp<br />
tests/core/playlists/TestPlaylistObserver.cpp<br />
tests/dynamic/CMakeLists.txt<br />
tests/dynamic/TestDynamicModel.cpp<br />
tests/dynamic/TestTrackSet.cpp<br />
tests/importers/ImporterMocks.cpp<br />
tests/importers/TestAmarokImporter.cpp<br />
tests/importers/TestBansheeImporter.cpp<br />
tests/importers/TestClementineImporter.cpp<br />
tests/importers/TestFastForwardImporter.cpp<br />
tests/importers/TestITunesImporter.cpp<br />
tests/importers/TestImporterBase.cpp<br />
tests/importers/TestImporterBase.h<br />
tests/importers/TestImporterManager.cpp<br />
tests/importers/TestImporterManager.h<br />
tests/importers/TestImporterProvider.cpp<br />
tests/importers/TestRhythmboxImporter.cpp<br />
tests/importers/TestSimpleImporterConfigWidget.cpp<br />
tests/playlist/CMakeLists.txt<br />
tests/playlist/TestPlaylistModels.cpp<br />
tests/playlistmanager/file/TestPlaylistFileProvider.cpp<br />
tests/playlistmanager/sql/TestSqlUserPlaylistProvider.cpp<br />
tests/scanner/CMakeLists.txt<br />
tests/scanner/TestGenericScanManager.cpp<br />
tests/scanner/TestGenericScanManager.h<br />
tests/synchronization/CMakeLists.txt<br />
tests/synchronization/TestMasterSlaveSynchronizationJob.cpp<br />
tests/synchronization/TestOneWaySynchronizationJob.cpp<br />
tests/synchronization/TestUnionJob.cpp<br />
tests/timecode/CMakeLists.txt<br />
tests/timecode/TestTimecodeTrackProvider.cpp</div></div></div><br /><div><strong>To: </strong>malteveerman, Amarok<br /><strong>Cc: </strong>Amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker<br /></div>