<table><tr><td style="">malteveerman created this revision.<br />malteveerman added a reviewer: Amarok.<br />malteveerman added a project: Amarok.<br />malteveerman requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10526" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This patch ports the core app away from kdelibs4 to pure qt5/kf5. Kdelibs4 classes that don't have an equivalent in qt5 or kf5 like KSharedPtr or KHBox were replaced by new ones (AmarokSharedPtr and BoxWidget).<br />

There are also a lot of small fixes and changes in this patch, which I unfortunately cannot break off into their own revisions, because I lost my git history to a faulty hard drive and my only backup was months old. Sorry for that.<br />

I also temporarily deactivated the tests. They get ported and reactivated in a later patch to keep the scope of this at least somewhat manageable. Also in later patches are a new qml context area with the most important applets, some services and importers. It's all finished and ready for merge as soon as this patch lands.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R181 Amarok</div></div></div><br /><div><strong>BRANCH</strong><div><div>kf5</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10526" rel="noreferrer">https://phabricator.kde.org/D10526</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

shared/CMakeLists.txt<br />

shared/MetaTagLib.cpp<br />

shared/amarokshared_export.h<br />

shared/tag_helpers/ID3v2TagHelper.cpp<br />

src/ActionClasses.cpp<br />

src/ActionClasses.h<br />

src/AmarokMimeData.cpp<br />

src/AmarokMimeData.h<br />

src/AmarokProcess.h<br />

src/AmarokSharedPointer.h<br />

src/App.cpp<br />

src/App.h<br />

src/CMakeLists.txt<br />

src/EngineController.cpp<br />

src/EngineController.h<br />

src/GlobalCollectionActions.cpp<br />

src/GlobalCollectionActions.h<br />

src/GlobalCurrentTrackActions.cpp<br />

src/GlobalCurrentTrackActions.h<br />

src/KNotificationBackend.cpp<br />

src/KNotificationBackend.h<br />

src/LastfmReadLabelCapability.cpp<br />

src/MainWindow.cpp<br />

src/MainWindow.h<br />

src/MediaDeviceCache.cpp<br />

src/MediaDeviceCache.h<br />

src/MediaDeviceMonitor.cpp<br />

src/MediaDeviceMonitor.h<br />

src/OpmlParser.cpp<br />

src/OpmlParser.h<br />

src/OpmlWriter.h<br />

src/PaletteHandler.cpp<br />

src/PaletteHandler.h<br />

src/PluginManager.h<br />

src/PopupDropperFactory.cpp<br />

src/PopupDropperFactory.h<br />

src/QStringx.cpp<br />

src/QStringx.h<br />

src/SvgHandler.cpp<br />

src/SvgHandler.h<br />

src/SvgTinter.cpp<br />

src/SvgTinter.h<br />

src/TrayIcon.cpp<br />

src/TrayIcon.h<br />

src/aboutdialog/ExtendedAboutDialog.cpp<br />

src/aboutdialog/ExtendedAboutDialog.h<br />

src/aboutdialog/OcsPersonItem.cpp<br />

src/aboutdialog/OcsPersonItem.h<br />

src/aboutdialog/libattica-ocsclient/CMakeLists.txt<br />

src/aboutdialog/libattica-ocsclient/activitylistjob.cpp<br />

src/aboutdialog/libattica-ocsclient/atticaclient_export.h<br />

src/aboutdialog/libattica-ocsclient/categorylistjob.cpp<br />

src/aboutdialog/libattica-ocsclient/contentjob.cpp<br />

src/aboutdialog/libattica-ocsclient/contentlistjob.cpp<br />

src/aboutdialog/libattica-ocsclient/folderlistjob.cpp<br />

src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp<br />

src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp<br />

src/aboutdialog/libattica-ocsclient/messagelistjob.cpp<br />

src/aboutdialog/libattica-ocsclient/personjob.cpp<br />

src/aboutdialog/libattica-ocsclient/personlistjob.cpp<br />

src/aboutdialog/libattica-ocsclient/postjob.cpp<br />

src/aboutdialog/libattica-ocsclient/provider.cpp<br />

src/amarok_export.h<br />

src/amarokconfig.kcfg<br />

src/amarokurls/AmarokUrl.cpp<br />

src/amarokurls/AmarokUrlHandler.cpp<br />

src/amarokurls/BookmarkCurrentButton.cpp<br />

src/amarokurls/BookmarkGroup.cpp<br />

src/amarokurls/BookmarkGroup.h<br />

src/amarokurls/BookmarkManager.cpp<br />

src/amarokurls/BookmarkManagerWidget.cpp<br />

src/amarokurls/BookmarkManagerWidget.h<br />

src/amarokurls/BookmarkMetaActions.cpp<br />

src/amarokurls/BookmarkModel.cpp<br />

src/amarokurls/BookmarkModel.h<br />

src/amarokurls/BookmarkTreeView.cpp<br />

src/amarokurls/BookmarkViewItem.h<br />

src/amarokurls/ContextUrlGenerator.cpp<br />

src/amarokurls/ContextUrlRunner.cpp<br />

src/amarokurls/NavigationUrlGenerator.cpp<br />

src/amarokurls/NavigationUrlRunner.cpp<br />

src/amarokurls/PlayUrlGenerator.cpp<br />

src/browsers/BrowserBreadcrumbItem.cpp<br />

src/browsers/BrowserBreadcrumbItem.h<br />

src/browsers/BrowserBreadcrumbWidget.cpp<br />

src/browsers/BrowserBreadcrumbWidget.h<br />

src/browsers/BrowserCategory.cpp<br />

src/browsers/BrowserCategory.h<br />

src/browsers/BrowserCategoryList.cpp<br />

src/browsers/BrowserDock.cpp<br />

src/browsers/BrowserDock.h<br />

src/browsers/BrowserMessageArea.cpp<br />

src/browsers/BrowserMessageArea.h<br />

src/browsers/CollectionSortFilterProxyModel.cpp<br />

src/browsers/CollectionSortFilterProxyModel.h<br />

src/browsers/CollectionTreeItem.cpp<br />

src/browsers/CollectionTreeItemModel.cpp<br />

src/browsers/CollectionTreeItemModelBase.cpp<br />

src/browsers/CollectionTreeItemModelBase.h<br />

src/browsers/CollectionTreeView.cpp<br />

src/browsers/CollectionTreeView.h<br />

src/browsers/InfoProxy.cpp<br />

src/browsers/SingleCollectionTreeItemModel.cpp<br />

src/browsers/collectionbrowser/CollectionWidget.cpp<br />

src/browsers/filebrowser/FileBrowser.cpp<br />

src/browsers/filebrowser/FileBrowser_p.h<br />

src/browsers/filebrowser/FileView.cpp<br />

src/browsers/filebrowser/FileView.h<br />

src/browsers/playlistbrowser/APGCategory.cpp<br />

src/browsers/playlistbrowser/DynamicBiasDialog.cpp<br />

src/browsers/playlistbrowser/DynamicBiasDialog.h<br />

src/browsers/playlistbrowser/DynamicCategory.cpp<br />

src/browsers/playlistbrowser/DynamicView.cpp<br />

src/browsers/playlistbrowser/PlaylistBrowser.cpp<br />

src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp<br />

src/browsers/playlistbrowser/PlaylistBrowserCategory.h<br />

src/browsers/playlistbrowser/PlaylistBrowserView.cpp<br />

src/browsers/playlistbrowser/PlaylistViewItem.h<br />

src/browsers/playlistbrowser/PlaylistsByProviderProxy.h<br />

src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp<br />

src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h<br />

src/browsers/playlistbrowser/PodcastCategory.cpp<br />

src/browsers/playlistbrowser/PodcastModel.cpp<br />

src/browsers/playlistbrowser/PodcastModel.h<br />

src/browsers/playlistbrowser/QtGroupingProxy.h<br />

src/browsers/playlistbrowser/UserPlaylistCategory.cpp<br />

src/browsers/playlistbrowser/UserPlaylistCategory.h<br />

src/browsers/servicebrowser/ServiceBrowser.cpp<br />

src/browsers/servicebrowser/ServiceBrowser.h<br />

src/configdialog/ConfigDialog.cpp<br />

src/configdialog/ConfigDialog.h<br />

src/configdialog/dialogs/CollectionConfig.cpp<br />

src/configdialog/dialogs/CollectionConfig.ui<br />

src/configdialog/dialogs/DatabaseConfig.cpp<br />

src/configdialog/dialogs/ExcludedLabelsDialog.cpp<br />

src/configdialog/dialogs/ExcludedLabelsDialog.h<br />

src/configdialog/dialogs/ExcludedLabelsDialog.ui<br />

src/configdialog/dialogs/GeneralConfig.cpp<br />

src/configdialog/dialogs/GeneralConfig.ui<br />

src/configdialog/dialogs/MetadataConfig.cpp<br />

src/configdialog/dialogs/MetadataConfig.h<br />

src/configdialog/dialogs/NotificationsConfig.ui<br />

src/configdialog/dialogs/PlaybackConfig.cpp<br />

src/configdialog/dialogs/PluginsConfig.cpp<br />

src/configdialog/dialogs/ScriptSelector.cpp<br />

src/configdialog/dialogs/ScriptSelector.h<br />

src/configdialog/dialogs/ScriptsConfig.cpp<br />

src/configdialog/dialogs/ScriptsConfig.h<br />

src/configdialog/dialogs/ScriptsConfig.ui<br />

src/context/CMakeLists.txt<br />

src/context/LyricsManager.cpp<br />

src/context/LyricsManager.h<br />

src/context/popupdropper/libpud/PopupDropper.cpp<br />

src/context/popupdropper/libpud/PopupDropperItem.cpp<br />

src/core-impl/capabilities/timecode/TimecodeLoadCapability.h<br />

src/core-impl/capabilities/timecode/TimecodeWriteCapability.cpp<br />

src/core-impl/collections/CMakeLists.txt<br />

src/core-impl/collections/aggregate/AggregateCollection.cpp<br />

src/core-impl/collections/aggregate/AggregateCollection.h<br />

src/core-impl/collections/aggregate/AggregateMeta.cpp<br />

src/core-impl/collections/aggregate/AggregateQueryMaker.cpp<br />

src/core-impl/collections/aggregate/AggregateQueryMaker.h<br />

src/core-impl/collections/audiocd/AudioCdCollection.cpp<br />

src/core-impl/collections/audiocd/AudioCdCollection.h<br />

src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp<br />

src/core-impl/collections/audiocd/AudioCdMeta.h<br />

src/core-impl/collections/audiocd/CMakeLists.txt<br />

src/core-impl/collections/audiocd/FormatSelectionDialog.cpp<br />

src/core-impl/collections/audiocd/handler/AudioCdHandler.cpp<br />

src/core-impl/collections/daap/CMakeLists.txt<br />

src/core-impl/collections/daap/DaapCollection.cpp<br />

src/core-impl/collections/daap/DaapCollection.h<br />

src/core-impl/collections/daap/DaapMeta.h<br />

src/core-impl/collections/daap/daapreader/Reader.cpp<br />

src/core-impl/collections/daap/daapreader/Reader.h<br />

src/core-impl/collections/daap/daapreader/authentication/contentfetcher.cpp<br />

src/core-impl/collections/daap/daapreader/authentication/contentfetcher.h<br />

src/core-impl/collections/db/MountPointManager.cpp<br />

src/core-impl/collections/db/MountPointManager.h<br />

src/core-impl/collections/db/sql/CMakeLists.txt<br />

src/core-impl/collections/db/sql/DatabaseUpdater.cpp<br />

src/core-impl/collections/db/sql/SqlCapabilities.cpp<br />

src/core-impl/collections/db/sql/SqlCapabilities.h<br />

src/core-impl/collections/db/sql/SqlCollection.cpp<br />

src/core-impl/collections/db/sql/SqlCollectionLocation.cpp<br />

src/core-impl/collections/db/sql/SqlCollectionLocation.h<br />

src/core-impl/collections/db/sql/SqlMeta.cpp<br />

src/core-impl/collections/db/sql/SqlMeta.h<br />

src/core-impl/collections/db/sql/SqlQueryMaker.cpp<br />

src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp<br />

src/core-impl/collections/db/sql/SqlQueryMakerInternal.h<br />

src/core-impl/collections/db/sql/SqlRegistry.cpp<br />

src/core-impl/collections/db/sql/SqlRegistry.h<br />

src/core-impl/collections/db/sql/SqlRegistry_p.cpp<br />

src/core-impl/collections/db/sql/amarok_sqlcollection_export.h<br />

src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.h<br />

src/core-impl/collections/db/sql/mysqlcollection/CMakeLists.txt<br />

src/core-impl/collections/ipodcollection/CMakeLists.txt<br />

src/core-impl/collections/ipodcollection/IpodCollection.cpp<br />

src/core-impl/collections/ipodcollection/IpodCollection.h<br />

src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp<br />

src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp<br />

src/core-impl/collections/ipodcollection/IpodCollectionLocation.h<br />

src/core-impl/collections/ipodcollection/IpodMeta.cpp<br />

src/core-impl/collections/ipodcollection/IpodMeta.h<br />

src/core-impl/collections/ipodcollection/IpodPlaylist.cpp<br />

src/core-impl/collections/ipodcollection/IpodPlaylist.h<br />

src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp<br />

src/core-impl/collections/ipodcollection/IpodPlaylistProvider.h<br />

src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp<br />

src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h<br />

src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.cpp<br />

src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.h<br />

src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp<br />

src/core-impl/collections/ipodcollection/support/IphoneMountPoint.cpp<br />

src/core-impl/collections/ipodcollection/support/IpodDeviceHelper.cpp<br />

src/core-impl/collections/ipodcollection/support/IpodDeviceHelper.h<br />

src/core-impl/collections/ipodcollection/support/IpodTranscodeCapability.cpp<br />

src/core-impl/collections/ipodcollection/support/IpodTranscodeCapability.h<br />

src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp<br />

src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp<br />

src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h<br />

src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandlerCapability.h<br />

src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.h<br />

src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.cpp<br />

src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.h<br />

src/core-impl/collections/mediadevicecollection/podcast/MediaDevicePodcastMeta.h<br />

src/core-impl/collections/mediadevicecollection/support/ConnectionAssistant.cpp<br />

src/core-impl/collections/mediadevicecollection/support/mediadevicecollection_export.h<br />

src/core-impl/collections/mtpcollection/CMakeLists.txt<br />

src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp<br />

src/core-impl/collections/mtpcollection/handler/MtpHandler.h<br />

src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.cpp<br />

src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.h<br />

src/core-impl/collections/nepomukcollection/CMakeLists.txt<br />

src/core-impl/collections/nepomukcollection/NepomukParser.cpp<br />

src/core-impl/collections/playdarcollection/CMakeLists.txt<br />

src/core-impl/collections/playdarcollection/PlaydarCollection.cpp<br />

src/core-impl/collections/playdarcollection/PlaydarCollection.h<br />

src/core-impl/collections/playdarcollection/PlaydarMeta.cpp<br />

src/core-impl/collections/playdarcollection/PlaydarMeta.h<br />

src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp<br />

src/core-impl/collections/playdarcollection/PlaydarQueryMaker.h<br />

src/core-impl/collections/playdarcollection/support/Controller.cpp<br />

src/core-impl/collections/playdarcollection/support/Controller.h<br />

src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp<br />

src/core-impl/collections/playdarcollection/support/Query.cpp<br />

src/core-impl/collections/playdarcollection/support/Query.h<br />

src/core-impl/collections/support/ArtistHelper.cpp<br />

(338 more files...)</div></div></div><br /><div><strong>To: </strong>malteveerman, Amarok<br /><strong>Cc: </strong>Amarok, yaohanchen, malteveerman, markey, progwolff, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber<br /></div>