<div dir="ltr"><div>Forwarded to get more exposure. FYI, sysadmins have now also subscribed this mailing list to Phabricator, so in the future we will get notifications.</div><div><br></div><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Malte Veerman</b> <span dir="ltr"><<a href="mailto:noreply@phabricator.kde.org">noreply@phabricator.kde.org</a>></span><br>Date: Mon, Oct 9, 2017 at 11:53 PM<br>Subject: D8229: streamlined plugin system<br>To: <a href="mailto:kretschmann@kde.org">kretschmann@kde.org</a><br><br><br><table><tbody><tr><td>malteveerman updated this revision to Diff 20542.<br>malteveerman added a comment.

</td><td><a style="text-decoration:none;padding:4px 8px;margin:0 8px 8px;float:right;color:#464c5c;font-weight:bold;border-radius:3px;background-color:#f7f7f9;background-image:linear-gradient(to bottom,#fff,#f1f0f1);display:inline-block;border:1px solid rgba(71,87,120,.2)" href="https://phabricator.kde.org/D8229" rel="noreferrer" target="_blank">View Revision</a></td></tr></tbody></table><br><div><div><p>Added new amarok-plugin.metadata file.</p></div></div><br><div><strong>REPOSITORY</strong><div><div>R181 Amarok</div></div></div><br><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D8229?vs=20540&id=20542" rel="noreferrer" target="_blank">https://phabricator.kde.org/<wbr>D8229?vs=20540&id=20542</a></div></div><br><div><strong>BRANCH</strong><div><div>qt5/kf5</div></div></div><br><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8229" rel="noreferrer" target="_blank">https://phabricator.kde.org/<wbr>D8229</a></div></div><br><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br>

src/PluginManager.cpp<br>

src/PluginManager.h<br>

src/amarok-plugin.desktop<br>

src/amarok_plugin.desktop<br>

src/amarokurls/AmarokUrl.cpp<br>

src/amarokurls/BookmarkModel.<wbr>cpp<br>

src/configdialog/dialogs/<wbr>PluginsConfig.h<br>

src/core-impl/collections/<wbr>audiocd/AudioCdCollection.cpp<br>

src/core-impl/collections/<wbr>audiocd/AudioCdCollection.h<br>

src/core-impl/collections/<wbr>audiocd/amarok_collection-<wbr>audiocdcollection.desktop<br>

src/core-impl/collections/<wbr>daap/DaapCollection.cpp<br>

src/core-impl/collections/<wbr>daap/DaapCollection.h<br>

src/core-impl/collections/<wbr>daap/amarok_collection-<wbr>daapcollection.desktop<br>

src/core-impl/collections/db/<wbr>MountPointManager.cpp<br>

src/core-impl/collections/db/<wbr>MountPointManager.h<br>

src/core-impl/collections/db/<wbr>sql/DatabaseUpdater.cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlCollection.cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlCollection.h<br>

src/core-impl/collections/db/<wbr>sql/SqlCollectionFactory.cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlCollectionFactory.h<br>

src/core-impl/collections/db/<wbr>sql/SqlMeta.cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlMeta.h<br>

src/core-impl/collections/db/<wbr>sql/SqlQueryMaker.cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlReadLabelCapability.cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlReadLabelCapability.h<br>

src/core-impl/collections/db/<wbr>sql/SqlRegistry.cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlRegistry_p.h<br>

src/core-impl/collections/db/<wbr>sql/SqlScanResultProcessor.cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlWriteLabelCapability.<wbr>cpp<br>

src/core-impl/collections/db/<wbr>sql/SqlWriteLabelCapability.h<br>

src/core-impl/collections/db/<wbr>sql/device/massstorage/<wbr>MassStorageDeviceHandler.cpp<br>

src/core-impl/collections/db/<wbr>sql/device/massstorage/<wbr>MassStorageDeviceHandler.h<br>

src/core-impl/collections/db/<wbr>sql/device/nfs/<wbr>NfsDeviceHandler.cpp<br>

src/core-impl/collections/db/<wbr>sql/device/nfs/<wbr>NfsDeviceHandler.h<br>

src/core-impl/collections/db/<wbr>sql/device/smb/<wbr>SmbDeviceHandler.cpp<br>

src/core-impl/collections/db/<wbr>sql/device/smb/<wbr>SmbDeviceHandler.h<br>

src/core-impl/collections/db/<wbr>sql/mysqlcollection/<wbr>CMakeLists.txt<br>

src/core-impl/collections/db/<wbr>sql/mysqlcollection/<wbr>MySqlCollectionFactory.cpp<br>

src/core-impl/collections/db/<wbr>sql/mysqlcollection/<wbr>MySqlCollectionFactory.h<br>

src/core-impl/collections/db/<wbr>sql/mysqlcollection/amarok_<wbr>collection-mysqlcollection.<wbr>desktop<br>

src/core-impl/collections/<wbr>ipodcollection/<wbr>IpodCollectionFactory.cpp<br>

src/core-impl/collections/<wbr>ipodcollection/<wbr>IpodCollectionFactory.h<br>

src/core-impl/collections/<wbr>ipodcollection/amarok_<wbr>collection-ipodcollection.<wbr>desktop<br>

src/core-impl/collections/<wbr>mediadevicecollection/<wbr>MediaDeviceCollection.cpp<br>

src/core-impl/collections/<wbr>mediadevicecollection/<wbr>MediaDeviceCollection.h<br>

src/core-impl/collections/<wbr>mediadevicecollection/amarok_<wbr>collection-<wbr>mediadevicecollection.desktop<br>

src/core-impl/collections/<wbr>mtpcollection/MtpCollection.<wbr>cpp<br>

src/core-impl/collections/<wbr>mtpcollection/MtpCollection.h<br>

src/core-impl/collections/<wbr>mtpcollection/amarok_<wbr>collection-mtpcollection.<wbr>desktop<br>

src/core-impl/collections/<wbr>nepomukcollection/amarok_<wbr>collection-nepomukcollection.<wbr>desktop<br>

src/core-impl/collections/<wbr>playdarcollection/<wbr>PlaydarCollection.cpp<br>

src/core-impl/collections/<wbr>playdarcollection/<wbr>PlaydarCollection.h<br>

src/core-impl/collections/<wbr>playdarcollection/amarok_<wbr>collection-playdarcollection.<wbr>desktop<br>

src/core-impl/collections/<wbr>support/CollectionManager.cpp<br>

src/core-impl/collections/<wbr>umscollection/UmsCollection.<wbr>cpp<br>

src/core-impl/collections/<wbr>umscollection/UmsCollection.h<br>

src/core-impl/collections/<wbr>umscollection/amarok_<wbr>collection-umscollection.<wbr>desktop<br>

src/core-impl/collections/<wbr>upnpcollection/<wbr>UpnpCollectionFactory.cpp<br>

src/core-impl/collections/<wbr>upnpcollection/<wbr>UpnpCollectionFactory.h<br>

src/core-impl/collections/<wbr>upnpcollection/amarok_<wbr>collection-upnpcollection.<wbr>desktop<br>

src/core-impl/podcasts/sql/<wbr>SqlPodcastMeta.cpp<br>

src/core-impl/podcasts/sql/<wbr>SqlPodcastProvider.cpp<br>

src/core-impl/storage/<wbr>StorageManager.cpp<br>

src/core-impl/storage/<wbr>StorageManager.h<br>

src/core-impl/storage/sql/<wbr>mysqlestorage/CMakeLists.txt<br>

src/core-impl/storage/sql/<wbr>mysqlestorage/<wbr>MySqlEmbeddedStorageFactory.<wbr>cpp<br>

src/core-impl/storage/sql/<wbr>mysqlestorage/<wbr>MySqlEmbeddedStorageFactory.h<br>

src/core-impl/storage/sql/<wbr>mysqlestorage/amarok_storage-<wbr>mysqlestorage.desktop<br>

src/core-impl/storage/sql/<wbr>mysqlserverstorage/CMakeLists.<wbr>txt<br>

src/core-impl/storage/sql/<wbr>mysqlserverstorage/<wbr>MySqlServerStorageFactory.cpp<br>

src/core-impl/storage/sql/<wbr>mysqlserverstorage/<wbr>MySqlServerStorageFactory.h<br>

src/core-impl/storage/sql/<wbr>mysqlserverstorage/amarok_<wbr>storage-mysqlserverstorage.<wbr>desktop<br>

src/core-impl/support/<wbr>TagStatisticsStore.cpp<br>

src/core-impl/support/<wbr>UrlStatisticsStore.cpp<br>

src/core/collections/<wbr>Collection.cpp<br>

src/core/collections/<wbr>Collection.h<br>

src/core/storage/<wbr>StorageFactory.cpp<br>

src/core/storage/<wbr>StorageFactory.h<br>

src/core/support/<wbr>PluginFactory.cpp<br>

src/core/support/<wbr>PluginFactory.h<br>

src/importers/ImporterManager.<wbr>cpp<br>

src/importers/ImporterManager.<wbr>h<br>

src/importers/<wbr>SimpleImporterManager.h<br>

src/importers/amarok/<wbr>AmarokManager.cpp<br>

src/importers/amarok/<wbr>AmarokManager.h<br>

src/importers/amarok/amarok_<wbr>importer-amarok.desktop<br>

src/importers/banshee/<wbr>BansheeManager.cpp<br>

src/importers/banshee/amarok_<wbr>importer-banshee.desktop<br>

src/importers/clementine/<wbr>ClementineManager.cpp<br>

src/importers/clementine/<wbr>amarok_importer-clementine.<wbr>desktop<br>

src/importers/fastforward/<wbr>FastForwardManager.cpp<br>

src/importers/fastforward/<wbr>amarok_importer-fastforward.<wbr>desktop<br>

src/importers/itunes/<wbr>ITunesManager.cpp<br>

src/importers/itunes/amarok_<wbr>importer-itunes.desktop<br>

src/importers/rhythmbox/<wbr>RhythmboxManager.cpp<br>

src/importers/rhythmbox/<wbr>amarok_importer-rhythmbox.<wbr>desktop<br>

src/playlistmanager/file/<wbr>PlaylistFileProvider.h<br>

src/playlistmanager/sql/<wbr>SqlPlaylist.cpp<br>

src/playlistmanager/sql/<wbr>SqlPlaylistGroup.cpp<br>

src/playlistmanager/sql/<wbr>SqlUserPlaylistProvider.cpp<br>

src/services/ServiceBase.cpp<br>

src/services/ServiceBase.h<br>

src/services/<wbr>ServiceSqlCollection.cpp<br>

src/services/<wbr>ServiceSqlQueryMaker.cpp<br>

src/services/ampache/<wbr>AmpacheService.cpp<br>

src/services/ampache/<wbr>AmpacheService.h<br>

src/services/ampache/<wbr>AmpacheServiceQueryMaker.cpp<br>

src/services/ampache/<wbr>AmpacheSettings.cpp<br>

src/services/ampache/amarok_<wbr>service_ampache.desktop<br>

src/services/ampache/amarok_<wbr>service_ampache_config.desktop<br>

src/services/gpodder/<wbr>GpodderService.cpp<br>

src/services/gpodder/<wbr>GpodderService.h<br>

src/services/gpodder/amarok_<wbr>service_gpodder.desktop<br>

src/services/jamendo/<wbr>JamendoDatabaseHandler.cpp<br>

src/services/jamendo/<wbr>JamendoService.cpp<br>

src/services/jamendo/<wbr>JamendoService.h<br>

src/services/jamendo/amarok_<wbr>service_jamendo.desktop<br>

src/services/lastfm/<wbr>LastFmService.cpp<br>

src/services/lastfm/<wbr>LastFmService.h<br>

src/services/lastfm/amarok_<wbr>service_lastfm.desktop<br>

src/services/magnatune/<wbr>MagnatuneDatabaseHandler.cpp<br>

src/services/magnatune/<wbr>MagnatuneDatabaseWorker.cpp<br>

src/services/magnatune/<wbr>MagnatuneSettingsModule.cpp<br>

src/services/magnatune/<wbr>MagnatuneStore.cpp<br>

src/services/magnatune/<wbr>MagnatuneStore.h<br>

src/services/magnatune/amarok_<wbr>service_magnatunestore.desktop<br>

src/services/mp3tunes/<wbr>Mp3tunesService.cpp<br>

src/services/mp3tunes/<wbr>Mp3tunesService.h<br>

src/services/mp3tunes/amarok_<wbr>service_mp3tunes.desktop<br>

src/services/opmldirectory/<wbr>OpmlDirectoryService.cpp<br>

src/services/opmldirectory/<wbr>OpmlDirectoryService.h<br>

src/services/opmldirectory/<wbr>amarok_service_opmldirectory.<wbr>desktop<br>

src/statsyncing/Controller.h<br>

src/statsyncing/Provider.h<br>

src/statsyncing/<wbr>ProviderFactory.cpp<br>

src/statsyncing/<wbr>ProviderFactory.h<br>

src/statsyncing/<wbr>ScrobblingService.h<br>

tests/core-impl/collections/<wbr>db/sql/<wbr>SqlMountPointManagerMock.h<br>

tests/core-impl/collections/<wbr>db/sql/TestDatabaseUpdater.cpp<br>

tests/core-impl/collections/<wbr>db/sql/TestDatabaseUpdater.h<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlAlbum.cpp<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlAlbum.h<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlArtist.cpp<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlArtist.h<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlCollection.cpp<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlCollection.h<br>

tests/core-impl/collections/<wbr>db/sql/<wbr>TestSqlCollectionLocation.cpp<br>

tests/core-impl/collections/<wbr>db/sql/<wbr>TestSqlCollectionLocation.h<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlQueryMaker.cpp<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlQueryMaker.h<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlScanManager.cpp<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlScanManager.h<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlTrack.cpp<br>

tests/core-impl/collections/<wbr>db/sql/TestSqlTrack.h</div></div></div><br><div><strong>To: </strong>malteveerman, Amarok<br></div></div><br></div>