<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129192/">https://git.reviewboard.kde.org/r/129192/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 23rd, 2017, 1:04 p.m. UTC, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, sorry for inactivity. Issue dropped.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OTOH I'm still thinking about value/risk of this change. Pro: according to standards. Con: existing .desktop links may stop working. Has anyone tested this for example with Amarok shortcut in panel, desktop in various DEs? Others, what do you think?</p></pre>
</blockquote>
<p>On February 26th, 2017, 4:38 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A link in the Plasma panel created with the old name will point to a non-existing desktop file.
Same for a link created into to the desktop (but not if the desktop is copied).
About the standards: the risk is having bugs coming from downstream distributions if the appstream checks are enforced.
On the other side, if 2.9 is going to be released soon, the change could go to the kf5 branch only (as I guess that whatever will happen after 2.9, there won't be new kdelibs4 versions). I'd still prefer to fix it now (with 2.9 going out "soon") than wait for the future Frameworks version.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pro: Works well on Wayland and allows using D-Bus activation. That is more important than "just" being standard compliant.</p></pre>
<br />
<p>- Matthias</p>
<br />
<p>On October 16th, 2016, 2:12 p.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok and Matthias Klumpp.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2016, 2:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- add the organization namespace to the desktop and then appdata files, according the specification;
- use the new directory for metadata (metainfo) files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles, the files are installed in the expected places.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(327ec10)</span></li>
<li>src/amarok.appdata.xml <span style="color: grey">(c580fd5)</span></li>
<li>src/amarok.desktop <span style="color: grey">()</span></li>
<li>src/amarok_containers.desktop <span style="color: grey">()</span></li>
<li>src/dbus/mpris2/MediaPlayer2.cpp <span style="color: grey">(a1d1bda)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129192/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>