<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126195/">https://git.reviewboard.kde.org/r/126195/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Februar 2nd, 2016, 6:34 vorm. UTC, <b>Matthias Berndt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On Februar 2nd, 2016, 12:25 nachm. UTC, <b>Myriam Schweingruber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">erm, you can't call ship it on your own requests, that would counteract the sense of the review request :-)</p></pre>
</blockquote>
<p>On Januar 21st, 2017, 12:41 vorm. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suggest you create a new review request, reviewers will easily skip reviews marked as "ship it" as they'll think someone else has already reviewed it.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can't be bothered, Amarok appears to be dead anyway. Besides, the whole model of having a collection of audio files you listen to seems to me anyway. E. g. Deezer has a wider selection of music than I could ever hope to amass, so what's the point?</p></pre>
<br />
<p>- Matthias</p>
<br />
<p>On November 28th, 2015, 10:04 nachm. UTC, Matthias Berndt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matthias Berndt.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2015, 10:04 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently in the tag guessing dialog a coloured version of the file name
is shown. The colours indicate where the individual tag values are taken
from. If any of the tag values appears twice in the file name, both
occurrences are coloured, even though only one should be, i. e. the one
he tag value is actually being derived from. This patch fixes this issue</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/TagsFromFileNameGuesser.h <span style="color: grey">(0aa94c5)</span></li>
<li>shared/TagsFromFileNameGuesser.cpp <span style="color: grey">(1152271)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(54e8957)</span></li>
<li>src/dialogs/TagGuesser.h <span style="color: grey">(55f5bfd)</span></li>
<li>src/dialogs/TagGuesser.cpp <span style="color: grey">(5b3267f)</span></li>
<li>src/dialogs/TagGuesserDialog.h <span style="color: grey">(2c1a753)</span></li>
<li>src/dialogs/TagGuesserDialog.cpp <span style="color: grey">(e6c427e)</span></li>
<li>tests/TestTagGuesser.cpp <span style="color: grey">(620ff98)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126195/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>