<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127458/">https://git.reviewboard.kde.org/r/127458/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Stefano Pettini.</div>
<p style="color: grey;"><i>Updated June 18, 2016, 12:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix for warnings, one of them a probable bug</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This fixes some minor C++ warnings: one unused variable and another one about operator precedence. However I think the last one was I bug, that I think I fixed. It was about bpm in SqlScanProcessor. In addition, some warnings regarding deprecated functions are addressed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/configdialog/dialogs/DatabaseConfig.cpp <span style="color: grey">(1cb2d97)</span></li>
<li>src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp <span style="color: grey">(ea9c911)</span></li>
<li>src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp <span style="color: grey">(5cdb693)</span></li>
<li>src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.cpp <span style="color: grey">(5b09f07)</span></li>
<li>src/services/mp3tunes/libmp3tunes/harmony.c <span style="color: grey">(ead0345)</span></li>
<li>src/statemanagement/DefaultApplicationController.cpp <span style="color: grey">(5886789)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127458/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>