<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127523/">https://git.reviewboard.kde.org/r/127523/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 30th, 2016, 12:48 a.m. CEST, <b>Myriam Schweingruber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hm, I fail to see why you would not build amarok with MySQL embedded, as that is the default database. Could you please specify why this patch is needed?</p></pre>
</blockquote>
<p>On March 30th, 2016, 5:05 a.m. CEST, <b>Matt Whitlock</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Gentoo's philosophy is all about lean-and-mean, compiling support only for those options that one actually uses. There is not "one size fits all," and all users build all software from source, using the configure flags best suited to their needs. The Gentoo ebuild for Amarok has a USE flag "embedded" that enables or disables support for MySQL Embedded using <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-DWITH_MYSQL_EMBEDDED</code> on the CMake command line. I have been running an Amarok built without MySQL Embedded for many years, as I run a full MySQL daemon on my system at all times anyway. The latest Amarok beta no longer builds successfully when MySQL Embedded is disabled. This patch is straightforward and logical and seems to be the obvious way to correct the build problem. (Indeed, I am listening to music in Amarok 2.8.90 right now that has been compiled without MySQL Embedded support by applying this patch to the build system.)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, then apply the patch to Gentoo, but why should we change what has always been the default, namely MySQL embedded? We leave it to the users if they want to use an external MySQL server, but that is not the default setup, default definitely is and always has been the embedded version. The external MySQL setup is entirely up to the users discretion, and not the default one.
Understand me well: if distributions think they want to change this, it's up to them, but it is not our default setup, so I see no reason to change this in our source.</p></pre>
<br />
<p>- Myriam</p>
<br />
<p>On March 29th, 2016, 6:27 p.m. CEST, Matt Whitlock wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matt Whitlock.</div>
<p style="color: grey;"><i>Updated March 29, 2016, 6:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch corrects a build failure when compiling Amarok without MySQL Embedded.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See <a href="https://bugs.gentoo.org/show_bug.cgi?id=566980" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Gentoo bug 566980</a>.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/db/sql/mysqlcollection/CMakeLists.txt <span style="color: grey">(244cde1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127523/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>