<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126005/">https://git.reviewboard.kde.org/r/126005/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any comments/reviews?</p></pre>
 <br />









<p>- Olivier Churlaud</p>


<br />
<p>On novembre 9th, 2015, 7:08 après-midi CET, Olivier Churlaud wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Olivier Churlaud.</div>


<p style="color: grey;"><i>Updated nov. 9, 2015, 7:08 après-midi</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I port some of the tests.. I would like your feedback on all this.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiled and path some tests:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The following tests FAILED:
16 - testtrackforurlworker (Failed)
24 - testplaylistobserver (Failed)
45 - testtrackloader (Failed)
46 - testdynamicmodel (Failed)  << Corrected but memory leak now.
49 - testplaylistfileprovider (Failed)</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/amarokurls/AmarokUrl.cpp <span style="color: grey">(e64a1ed)</span></li>

 <li>src/browsers/BrowserMessageArea.cpp <span style="color: grey">(13e6dd3)</span></li>

 <li>src/core-impl/meta/cue/CueFileSupport.cpp <span style="color: grey">(f39b7eb)</span></li>

 <li>src/core-impl/meta/file/File.cpp <span style="color: grey">(ac37887)</span></li>

 <li>src/core-impl/meta/timecode/TimecodeTrackProvider.cpp <span style="color: grey">(2c6fd52)</span></li>

 <li>src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp <span style="color: grey">(a6b448b)</span></li>

 <li>src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp <span style="color: grey">(6691a20)</span></li>

 <li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: grey">(8330c3d)</span></li>

 <li>src/core/support/Amarok.cpp <span style="color: grey">(1d83542)</span></li>

 <li>tests/core-impl/meta/file/TestMetaFileTrack.cpp <span style="color: grey">(b1ae0a6)</span></li>

 <li>tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp <span style="color: grey">(ab97410)</span></li>

 <li>tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp <span style="color: grey">(41ffa6c)</span></li>

 <li>tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.cpp <span style="color: grey">(ccf9465)</span></li>

 <li>tests/core-impl/playlists/types/file/xspf/TestXSPFPlaylist.cpp <span style="color: grey">(d865213)</span></li>

 <li>tests/core/collections/support/TestTrackForUrlWorker.h <span style="color: grey">(8f6c4aa)</span></li>

 <li>tests/core/collections/support/TestTrackForUrlWorker.cpp <span style="color: grey">(7d9bebf)</span></li>

 <li>tests/core/meta/TestMetaTrack.h <span style="color: grey">(0859988)</span></li>

 <li>tests/core/meta/TestMetaTrack.cpp <span style="color: grey">(0f5ee16)</span></li>

 <li>tests/dynamic/TestDynamicModel.cpp <span style="color: grey">(43664f5)</span></li>

 <li>tests/timecode/TestTimecodeTrackProvider.cpp <span style="color: grey">(82f66bb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126005/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>