<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126005/">https://git.reviewboard.kde.org/r/126005/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126005/diff/1/?file=415876#file415876line401" style="color: black; font-weight: bold; text-decoration: underline;">src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SqlScanResultProcessor::deleteDeletedDirectories()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">401</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="o">!</span><span class="n">m_foundDirectories</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span> <span class="n">path</span> <span class="p">)</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">401</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="o">!</span><span class="n">m_foundDirectories</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span> <span class="n">path</span> <span class="o"><span class="hl">+</span></span><span class="hl"> </span><span class="sc"><span class="hl">'/'</span></span><span class="hl"> </span><span class="p">)</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This line doesn't concern the tests but the sql issue (see mail <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Re: [KF5Port] Next-bug: mysql ?</em> of 07/11/2015 20:15)</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126005/diff/1/?file=415880#file415880line60" style="color: black; font-weight: bold; text-decoration: underline;">src/core/support/Amarok.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Amarok</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">KCalendarSystem</span> <span class="o">*</span><span class="n">cal</span> <span class="o">=</span> <span class="n">KGlobal</span><span class="o">::</span><span class="n">locale</span><span class="p">()</span><span class="o">-></span><span class="n">calendar</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1"><span class="hl">//</span>const KCalendarSystem *cal = KGlobal::locale()->calendar();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This comment should be removed.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126005/diff/1/?file=415884#file415884line60" style="color: black; font-weight: bold; text-decoration: underline;">tests/dynamic/TestDynamicModel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span class="n">s_tmpDir</span><span class="p">;</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this caused a segfault. Removing it solve the issue but causes a memory leak</p></pre>
</div>
</div>
<br />
<p>- Olivier Churlaud</p>
<br />
<p>On novembre 9th, 2015, 1:08 après-midi CET, Olivier Churlaud wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Olivier Churlaud.</div>
<p style="color: grey;"><i>Updated nov. 9, 2015, 1:08 après-midi</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I port some of the tests.. I would like your feedback on all this.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiled and path some tests:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">16 - testtrackforurlworker (Failed)
18 - testmetatrack (Failed)
26 - testsqldatabaseupdater (Failed)
27 - testsqlalbum (Failed)
28 - testsqlartist (Failed)
29 - testsqlcollection (Failed)
30 - testsqlquerymaker (Failed)
31 - testsqlscanmanager (Failed)
32 - testsqltrack (Failed)
33 - testsqlcollectionlocation (Failed)
37 - testcuefilesupport (Failed)
38 - testmetafiletrack (Failed)
40 - testasxplaylist (Failed)
41 - testm3uplaylist (Failed)
42 - testplsplaylist (Failed)
43 - testxspfplaylist (Failed)
45 - testtrackloader (Failed)
46 - testdynamicmodel (Failed) << Corrected but memory leak now.
49 - testplaylistfileprovider (Failed)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/amarokurls/AmarokUrl.cpp <span style="color: grey">(e64a1ed)</span></li>
<li>src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp <span style="color: grey">(441bac4)</span></li>
<li>src/core-impl/meta/timecode/TimecodeTrackProvider.cpp <span style="color: grey">(2c6fd52)</span></li>
<li>src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp <span style="color: grey">(6691a20)</span></li>
<li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: grey">(8330c3d)</span></li>
<li>src/core/support/Amarok.cpp <span style="color: grey">(1d83542)</span></li>
<li>tests/core/collections/support/TestTrackForUrlWorker.cpp <span style="color: grey">(7d9bebf)</span></li>
<li>tests/core/meta/TestMetaTrack.h <span style="color: grey">(0859988)</span></li>
<li>tests/core/meta/TestMetaTrack.cpp <span style="color: grey">(0f5ee16)</span></li>
<li>tests/dynamic/TestDynamicModel.cpp <span style="color: grey">(43664f5)</span></li>
<li>tests/timecode/TestTimecodeTrackProvider.cpp <span style="color: grey">(82f66bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>