<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125519/">https://git.reviewboard.kde.org/r/125519/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Olivier Churlaud.</div>
<div>By Aditya Dev Sharma.</div>
<p style="color: grey;"><i>Updated Oct. 5, 2015, 4:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 79eb948507f4e39e16d0fe8ccdff8cdc477baa28 by Aditya Dev Sharma to branch kf5.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Replaced the KApplication with QApplication and hence used isSavingSession()</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds 100 %
Fixed the error and changed all <KApplication> stuff to <QApplication> .
Commented qApp->setTopWidget() until further information.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.cpp <span style="color: grey">(ce1710f)</span></li>
<li>src/aboutdialog/ExtendedAboutDialog.cpp <span style="color: grey">(381905c)</span></li>
<li>src/amarokurls/BookmarkManager.cpp <span style="color: grey">(7c42ecf)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollection.cpp <span style="color: grey">(ca20601)</span></li>
<li>src/core/support/Amarok.h <span style="color: grey">(8d80de6)</span></li>
<li>src/core/support/Amarok.cpp <span style="color: grey">(411b89c)</span></li>
<li>src/core/support/Debug.cpp <span style="color: grey">(07af24a)</span></li>
<li>src/covermanager/CoverFetchingActions.cpp <span style="color: grey">(f66197e)</span></li>
<li>src/covermanager/CoverManager.cpp <span style="color: grey">(a408436)</span></li>
<li>src/covermanager/CoverViewDialog.cpp <span style="color: grey">(626ccb9)</span></li>
<li>src/dbus/mpris1/PlayerHandler.cpp <span style="color: grey">(acaa119)</span></li>
<li>src/dbus/mpris1/RootHandler.cpp <span style="color: grey">(6d1e3b3)</span></li>
<li>src/dbus/mpris1/TrackListHandler.cpp <span style="color: grey">(eb0b5ca)</span></li>
<li>src/dbus/mpris2/MediaPlayer2.cpp <span style="color: grey">(c928da0)</span></li>
<li>src/dialogs/DiagnosticDialog.cpp <span style="color: grey">(61dbde4)</span></li>
<li>src/dialogs/deviceconfiguredialog.cpp <span style="color: grey">(70a93ce)</span></li>
<li>src/dialogs/transferdialog.cpp <span style="color: grey">(45b6ed0)</span></li>
<li>src/playlist/view/listview/PrettyListView.cpp <span style="color: grey">(aabf0b4)</span></li>
<li>src/scripting/scriptengine/AmarokLyricsScript.cpp <span style="color: grey">(ccc7721)</span></li>
<li>src/services/mp3tunes/Mp3tunesHarmonyHandler.cpp <span style="color: grey">(bfebfe5)</span></li>
<li>src/toolbar/SlimToolbar.cpp <span style="color: grey">(68f6cfc)</span></li>
<li>src/widgets/Osd.cpp <span style="color: grey">(de33567)</span></li>
<li>src/widgets/PixmapViewer.cpp <span style="color: grey">(387f95d)</span></li>
<li>src/widgets/SliderWidget.cpp <span style="color: grey">(bf21922)</span></li>
<li>src/widgets/Token.cpp <span style="color: grey">(05a0b78)</span></li>
<li>src/widgets/TokenPool.cpp <span style="color: grey">(a13d97b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125519/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>