<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
I commit my patch now, please commit yours afterwards so that we
don't mess up everything :)<br>
<br>
Olivier<br>
<pre class="moz-signature" cols="72">Olivier CHURLAUD
Engineer Student at Ecole Centrale de Lyon
in Dual Degree at TU Berlin, M.Sc. Elektrotechnik
@: <a class="moz-txt-link-abbreviated" href="mailto:olivier@churlaud.com">olivier@churlaud.com</a>
tel: +49 (0)1575-2931348
in: <a class="moz-txt-link-freetext" href="http://linkedin.com/in/olivierchurlaud">http://linkedin.com/in/olivierchurlaud</a>
web: <a class="moz-txt-link-freetext" href="http://olivier.churlaud.com">http://olivier.churlaud.com</a> </pre>
<div class="moz-cite-prefix">Le 04/10/2015 15:44, Aditya Sharma a
écrit :<br>
</div>
<blockquote
cite="mid:CALHAJW5qatW+VD1x5cpBXeb0E21EwKMzh2Ejiyam-tL-1UBk+A@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">I'll commit anyway
today, so that everyone can work from the same basis...
If at the end, someone thinks it's not well made, the
commit can be reverted....<span class=""><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div>Changed all includes of KApplication to
QApplication.</div>
<div>Changed kapplication.h to qapplication.h</div>
<div>Changed kapp to qApp</div>
<div>Commented qApp->setTopWidget following the
advice here[1]</div>
</div>
</blockquote>
</span> Wasn't it already in the patch ?</div>
</blockquote>
<div><br>
</div>
<div>Many parts were left out. Such as when we closed the
Application, KApplication caused a run time error
regarding some sessionSaving() thing. So basically changed
all those KApplication and kapp instances with
QApplication and qApp.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class=""><br>
<blockquote type="cite">
<div dir="ltr">
<div>With this done, amarok builds 100% . However
an error pops up after I quit it from system
tray. Here's the backtrace[2] . </div>
<div><br>
</div>
</div>
</blockquote>
</span> My backtrace is not so complete, can you give
the command you used? I'm not good with gdb, so I'll be
happy to know how you add such a good one.<br>
</div>
</blockquote>
<div><br>
</div>
<div>I compiled it with Debug mode enabled. Rest is just the
Amarok crash report and the backtrace from the Developer
Information Tab. Still haven't next through it with gdb.
Will do once you commit everything.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <br>
Here is mine: <br>
- If I don't specify the plugins location, I see the
window correctly and this is the backtrace (can be
easily corrected I guess) i get [1] </div>
</blockquote>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <br>
- If I specify the plugin location with <br>
export
QT_PLUGIN_PATH=/home/olivier/Projets/bin_amarok/lib64/plugins<br>
I get [2] and the window doesn't show correctly.<br>
<br>
[1] <a moz-do-not-send="true"
href="https://paste.kde.org/phqeb6t9h" target="_blank">https://paste.kde.org/phqeb6t9h</a></div>
</blockquote>
<div><br>
</div>
<div>Did you apply the updated patch I emailed you yesterday
? sessionSaving() error should not have popped up then :\
. Kindly let me know of the same.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><br>
[2] <a moz-do-not-send="true"
href="https://paste.kde.org/p6vhsvwwe" target="_blank">https://paste.kde.org/p6vhsvwwe</a></div>
</blockquote>
<div><br>
</div>
<div>My guess for the window not showing correctly is that
we have to port it to the new QML and the existing JSON to
the new version.</div>
<div> </div>
<div>Regards</div>
<div>Aditya</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Amarok-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/amarok-devel">https://mail.kde.org/mailman/listinfo/amarok-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>