<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125126/">https://git.reviewboard.kde.org/r/125126/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Olivier Churlaud.</div>
<p style="color: grey;"><i>Updated sep. 13, 2015, 7:59 après-midi</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Commented parts of code needing the context folder + changing all Kio::Job job( 0 ) and derivated to job( )
here is the backtrace http://pastebin.com/s21KswyJ</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port of main.cpp and App</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().
I'm not able to trace it further.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please help me to port well the main + App class so that the play, pause (and so one) commands are well read and to deal correctly with the unique/multiple instance.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not able to trace it further.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/App.h <span style="color: grey">(2089981)</span></li>
<li>src/App.cpp <span style="color: grey">(6028bc8)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(afeef4a)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(d3bbc0b)</span></li>
<li>src/PluginManager.cpp <span style="color: grey">(a9a1c47)</span></li>
<li>src/TrayIcon.cpp <span style="color: grey">(be25497)</span></li>
<li>src/aboutdialog/libattica-ocsclient/activitylistjob.cpp <span style="color: grey">(77044cf)</span></li>
<li>src/aboutdialog/libattica-ocsclient/categorylistjob.cpp <span style="color: grey">(427011e)</span></li>
<li>src/aboutdialog/libattica-ocsclient/contentjob.cpp <span style="color: grey">(c307e07)</span></li>
<li>src/aboutdialog/libattica-ocsclient/contentlistjob.cpp <span style="color: grey">(d371db4)</span></li>
<li>src/aboutdialog/libattica-ocsclient/folderlistjob.cpp <span style="color: grey">(dc2c137)</span></li>
<li>src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp <span style="color: grey">(f678b56)</span></li>
<li>src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp <span style="color: grey">(a7d6b95)</span></li>
<li>src/aboutdialog/libattica-ocsclient/messagelistjob.cpp <span style="color: grey">(372412d)</span></li>
<li>src/aboutdialog/libattica-ocsclient/personjob.cpp <span style="color: grey">(455178c)</span></li>
<li>src/aboutdialog/libattica-ocsclient/personlistjob.cpp <span style="color: grey">(005542b)</span></li>
<li>src/aboutdialog/libattica-ocsclient/postjob.cpp <span style="color: grey">(cce72a3)</span></li>
<li>src/amarok.desktop <span style="color: grey">(433c757)</span></li>
<li>src/browsers/filebrowser/FileBrowser.cpp <span style="color: grey">(3d40d9b)</span></li>
<li>src/configdialog/dialogs/ScriptsConfig.cpp <span style="color: grey">(bbec667)</span></li>
<li>src/context/engines/songkick/SongkickEngine.cpp <span style="color: grey">(2291719)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.cpp <span style="color: grey">(fe6bafd)</span></li>
<li>src/core/podcasts/PodcastReader.cpp <span style="color: grey">(409fc62)</span></li>
<li>src/core/support/Components.cpp <span style="color: grey">(9f97eb6)</span></li>
<li>src/main.cpp <span style="color: grey">(385e047)</span></li>
<li>src/org.kde.amarok.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scanner/AbstractDirectoryWatcher.cpp <span style="color: grey">(168c68a)</span></li>
<li>src/scanner/GenericScanManager.cpp <span style="color: grey">(75a22cc)</span></li>
<li>src/scanner/GenericScannerJob.cpp <span style="color: grey">(a4558fd)</span></li>
<li>src/scripting/scriptmanager/ScriptManager.cpp <span style="color: grey">(bb62be1)</span></li>
<li>src/services/ServiceAlbumCoverDownloader.cpp <span style="color: grey">(d499f62)</span></li>
<li>src/services/lastfm/biases/WeeklyTopBias.cpp <span style="color: grey">(a12f9f7)</span></li>
<li>src/services/magnatune/MagnatuneAlbumDownloader.cpp <span style="color: grey">(5fc6584)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp <span style="color: grey">(0c5913a)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryInfoParser.cpp <span style="color: grey">(f6ac752)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125126/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>