<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124773/">https://git.reviewboard.kde.org/r/124773/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 13th, 2015, 4:59 p.m. UTC, <b>Olivier Churlaud</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding the code, everything seems fine. Now the real question is about the shortcuts. Are they really good? Logical?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not the one to judge on this. But a Shift+E for instance might have bad repercussions (if you type Editors in the search field, what happens? Is the slot triggered?)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If Mamarok says it's ok, then ship it.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well yes, there could be bad repurcussions for having same shortcuts. But that seems to be different for different people having different systems. For eg. I could use a shortcut already used above, for launching say yakuake. The user could still change these shortcuts from the GUI. So making absolutely unique shortcuts is difficult. I just took care that the shortcuts did not match any previous Global Shortcuts or even the ones used before.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll wait for Mamarok :)</p></pre>
<br />
<p>- Aditya</p>
<br />
<p>On September 6th, 2015, 5:30 p.m. UTC, Aditya Dev Sharma wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok, Myriam Schweingruber and Bart Cerneels.</div>
<div>By Aditya Dev Sharma.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2015, 5:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=300979">300979</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">JJ : Bug - 300979 : Patch to add some shortcuts for various actions in createActions() in MainWindow</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built and tested.
Removed the shortcuts that matched either the Amarok Global Shortcuts or the Standard Shortcuts of KDE.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clear Playlist : CTRL + SHIFT + C ---------------> SLOT(clear() )
Add Stream : CTRL + SHIFT + J ---------------> SLOT(slotAddStream() )
Export Playlits : CTRL + SHIFT + E ---------------> SLOT(exportPlaylist() )
Bookmarks Manager : CTRL + I ---------------> SLOT(slotShowBookmarkManager() )
Equalizer : SHIFT + E ---------------> SLOT(slotShowEqualizer() )
Cover Manager : CTRL + ALT + C ---------------> SLOT(slotShowCoverManager() )
Synchronize Statistics : SHIFT + S ---------------> SLOT(synchronize() )</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bookmark Media Sources View : SHIFT + B ----------> SLOT(bookmarkCurrentBrowserView() )
Bookmark Playlist Setup : ALT + B ---------------> bookmarkCurrentPlaylistView() )
Bookmark Context Applets : CTRL + SHIFT + B ------> bookmarkCurrentContextView() )
Disable Dynamic Playlist : ALT + SHIFT + D -------> connected inside dynamic playlist category</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About Amarok : ALT + F10 -----------------> SLOT(showAbout())
Diagnostics : ALT + F8 -----------------> SLOT(slotShowDiagnosticsDialog())
Report bug : ALT + F9 -----------------> SLOT(showReportBug())</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.cpp <span style="color: grey">(22fb8ce)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>