<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125126/">https://git.reviewboard.kde.org/r/125126/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125126/diff/2/?file=402961#file402961line363" style="color: black; font-weight: bold; text-decoration: underline;">src/App.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">App::handleCliArgs() //static</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">App::handleCliArgs(const QString &cwd)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">357</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">options</span><span class="p">.</span><span class="n">a<span class="hl">dd</span></span><span class="p">(</span><span class="s">"+[URL(s)]"</span><span class="p">,</span> <span class="n"><span class="hl">k</span>i18n</span><span class="p">(</span> <span class="s">"Files/URLs to open"</span> <span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">359</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">options</span><span class="p">.</span><span class="n">a<span class="hl">ppend</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QCommandLineOption</span></span><span class="p">(</span><span class="s">"+[URL(s)]"</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Files/URLs to open"</span> <span class="p">))<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should not be an option but a positionalArgument</p></pre>
</div>
</div>
<br />
<p>- Olivier Churlaud</p>
<br />
<p>On septembre 12th, 2015, 2:05 après-midi CEST, Olivier Churlaud wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Olivier Churlaud.</div>
<p style="color: grey;"><i>Updated sep. 12, 2015, 2:05 après-midi</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port of main.cpp and App</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().
I'm not able to trace it further.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please help me to port well the main + App class so that the play, pause (and so one) commands are well read and to deal correctly with the unique/multiple instance.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not able to trace it further.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/App.h <span style="color: grey">(2089981)</span></li>
<li>src/scripting/scriptmanager/ScriptManager.cpp <span style="color: grey">(bb62be1)</span></li>
<li>src/scanner/AbstractDirectoryWatcher.cpp <span style="color: grey">(168c68a)</span></li>
<li>src/org.kde.amarok.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main.cpp <span style="color: grey">(385e047)</span></li>
<li>src/core/support/Components.cpp <span style="color: grey">(9f97eb6)</span></li>
<li>src/configdialog/dialogs/ScriptsConfig.cpp <span style="color: grey">(bbec667)</span></li>
<li>src/amarok.desktop <span style="color: grey">(433c757)</span></li>
<li>src/browsers/filebrowser/FileBrowser.cpp <span style="color: grey">(3d40d9b)</span></li>
<li>src/TrayIcon.cpp <span style="color: grey">(be25497)</span></li>
<li>src/PluginManager.cpp <span style="color: grey">(a9a1c47)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(afeef4a)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(d3bbc0b)</span></li>
<li>src/App.cpp <span style="color: grey">(6028bc8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125126/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>