<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 11 August 2015 at 15:08, Olivier Churlaud <span dir="ltr"><<a href="mailto:olivier@churlaud.com" target="_blank">olivier@churlaud.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Le 11/08/2015 07:00, Aroonav Mishra a écrit :<br>
<blockquote type="cite">
<div dir="ltr">
<div>Hello Olivier,<br>
</div>
</div>
</blockquote>
Hi<span class=""><br>
<blockquote type="cite">
<div dir="ltr">I tried getting in touch with you on IRC about
this.<br>
<div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 10 August 2015 at 04:55,
Olivier Churlaud <span dir="ltr"><<a href="mailto:olivier@churlaud.com" target="_blank"></a><a href="mailto:olivier@churlaud.com" target="_blank">olivier@churlaud.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> @Aroonav:
it's specially for you...<br>
<br>
tell me what I'm supposed to do with this first
work (there are 3 commits in fact).<br>
</div>
</blockquote>
<div>If it's okay with you I would like to first
understand something. I had disabled the compilation
of the files in src/context in src/CMakeLists.txt in
the kf5 branch but I see that you have not
re-enabled their compilation in that cmake file. And
if I have understood correctly then I believe that
you are gonna look at the errors before making the
required changes to correct that error. So am I
correct in guessing that you <i>have</i> re-enabled
their compilation in your local repository but you
haven't put that change(of enabling the compilation
of src/context) in the commit on the reviewboard.<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote></span>
No. I let everything like you did. The first thing I did is "let see
what compiles" and I compiled the whole project, (with the CMakeList
like you let it). I took the first errors and made everything so
that the compilation go further.<span class=""><br></span></div></blockquote><div>Okay, cool. I am a little surprised (should I be?) that I am getting a different set of errors right now (on compilation of the code till the last commit pushed to the remote kf5 branch). The error that I am getting right now is (at 78%) in src/main.cpp related to KCmdLineArgs and a few other errors. Are we getting different errors due to our different development environment setups? What do you think?<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><span class="">
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <br>
With this I get 19% of the compilation. BUT I have
the KPluginInfo problem, plus a<br>
<blockquote><small>/usr/include/kcmodule.h:29:25:
fatal error: QtGui/QWidget: No such file or
directory</small><br>
</blockquote>
that I don't understand.<br>
</div>
</blockquote>
<div>
<div>It seems that the Qt/KF5 development libraries
are not installed(or not setup) properly on your
system. Because that seems to be the first reason
that comes to my mind for the error. It seems to
have found the kdelibs4 version of kcmodule.h and
that only seems plausible when the required kf5
package isn't found. Same goes for the KPluginInfo
problem that you have mentioned on the
reviewboard.<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote></span>
The KPluginInfo problem is solved (cf the update) and it was just a
problem of include.<br>
I have the kf5 package since I'm able to compile other parts of the
code based on kf5 (and I'm on archlinux, I compiled several apps
without pb).<br></div></blockquote><div>Do you have the KF5::KConfigWidgets installed for archlinux. I had a look at the <a href="https://www.archlinux.org/packages/extra/x86_64/kconfigwidgets/files/">filelist</a> (I am assuming 64-bit archlinux.) and the file kcmodule.h detected should be "usr/include/KF5/KConfigWidgets/kcmodule.h" but from the error, the cmake on your local environment detects the file in "usr/include/kcmodule.h" which is in the kdelibs package (<a href="https://www.archlinux.org/packages/extra/x86_64/kdelibs/files/">filelist</a>). What do you think about this?<span class="im"></span></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
Cheers<span class="HOEnZb"><font color="#888888"><br>
Olivier</font></span><div><div class="h5"><br>
<br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<div> <br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Thx<span><font color="#888888"><br>
Olivier</font></span>
<div>
<div><br>
<br>
<br>
<div>Le 10/08/2015 01:13, Olivier Churlaud a
écrit :<br>
</div>
<blockquote type="cite">
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table style="border:1px #c9c399 solid;border-radius:6px" width="100%" bgcolor="#f9f3c9" cellpadding="12">
<tbody>
<tr>
<td> This is an automatically
generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124678/" target="_blank">https://git.reviewboard.kde.org/r/124678/</a>
</td>
</tr>
</tbody>
</table>
<br>
<table style="border:1px #888a85 solid;border-radius:6px" width="100%" bgcolor="#fefadf" cellpadding="12" cellspacing="0">
<tbody>
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Olivier Churlaud.</div>
<div style="margin-top:1.5em"> <b style="color:#575012;font-size:10pt">Repository: </b> amarok </div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description
</h1>
<table style="border:1px solid #b8b5a0" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody>
<tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">It's my first port so I would like to have an external point of view.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Other problem, in the compilation, KPluginInfo is not found:</p>
<div style="background:#f8f8f8"><pre style="line-height:125%">/home/olivier/Projets/amarok/src/context/tools/amarokpkg.cpp:37:30: fatal error: Plasma/KPluginInfo: No such file or directory
</pre></div>
</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs
</h1>
<ul style="margin-left:3em;padding-left:0">
<li>shared/collectionscanner/ScanningState.cpp
<span style="color:grey">(488b5ec)</span></li>
<li>src/context/applets/wikipedia/WikipediaApplet.cpp
<span style="color:grey">(824e9b7)</span></li>
<li>src/context/tools/CMakeLists.txt
<span style="color:grey">(1deb7f3)</span></li>
<li>src/context/tools/amarokpkg.cpp
<span style="color:grey">(2ae1e93)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.cpp
<span style="color:grey">(46aa8fe)</span></li>
<li>tests/TestExpression.h <span style="color:grey">(cfa2a0c)</span></li>
<li>tests/TestQStringx.h <span style="color:grey">(8cf14c3)</span></li>
<li>tests/TestSmartPointerList.h
<span style="color:grey">(72c95aa)</span></li>
<li>tests/TestSmartPointerList.cpp
<span style="color:grey">(8e9865b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124678/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
</blockquote>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org" target="_blank">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<div class="gmail_extra">Cheers,<br>
</div>
<div class="gmail_extra">Aroonav.<br>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Amarok-devel mailing list
<a href="mailto:Amarok-devel@kde.org" target="_blank">Amarok-devel@kde.org</a>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
<br></blockquote></div>Cheers,<br></div><div class="gmail_extra">Aroonav<br></div></div>