<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124678/">https://git.reviewboard.kde.org/r/124678/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Olivier Churlaud.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's my first port so I would like to have an external point of view.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other problem, in the compilation, KPluginInfo is not found:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">/home/olivier/Projets/amarok/src/context/tools/amarokpkg.cpp:37:30: fatal error: Plasma/KPluginInfo: No such file or directory
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/collectionscanner/ScanningState.cpp <span style="color: grey">(488b5ec)</span></li>
<li>src/context/applets/wikipedia/WikipediaApplet.cpp <span style="color: grey">(824e9b7)</span></li>
<li>src/context/tools/CMakeLists.txt <span style="color: grey">(1deb7f3)</span></li>
<li>src/context/tools/amarokpkg.cpp <span style="color: grey">(2ae1e93)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.cpp <span style="color: grey">(46aa8fe)</span></li>
<li>tests/TestExpression.h <span style="color: grey">(cfa2a0c)</span></li>
<li>tests/TestQStringx.h <span style="color: grey">(8cf14c3)</span></li>
<li>tests/TestSmartPointerList.h <span style="color: grey">(72c95aa)</span></li>
<li>tests/TestSmartPointerList.cpp <span style="color: grey">(8e9865b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124678/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>