<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119659/">https://git.reviewboard.kde.org/r/119659/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The function AmarokLyricsScript::ttplayer_codeFunc has some strange comments.
Also, at least this function needs a lot more comments and readable variable names to be maintainable.</p></pre>
<br />
<p>- Ralf Engels</p>
<br />
<p>On August 8th, 2014, 10:04 vorm. UTC, Vedant Agarwala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok and Mark Kretschmann.</div>
<div>By Vedant Agarwala.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2014, 10:04 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have added an amarok script to download timestamped lyrics.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To test, use the diff uploaded with the request or checkout my personal branch: http://quickgit.kde.org/?p=clones/amarok/vedanta/sok.git&a=commit&h=c96f68db858b60a15eef47ddc7faad75ad792501</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The database (as it turns out) is quite small. (More scripts for the same need to be added in future) It works for the following songs:
1. Toxicity - System of a Down
2. Rockstar - Nickelback</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You will have to "reload lyrics", if you already have lyrics for that song.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/scripting/scriptengine/AmarokLyricsScript.h <span style="color: grey">(9711038)</span></li>
<li>src/scripting/scriptengine/AmarokLyricsScript.cpp <span style="color: grey">(de378dc)</span></li>
<li>src/scripting/scripts/CMakeLists.txt <span style="color: grey">(05ae586)</span></li>
<li>src/scripting/scripts/lrc_ttplayer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scripts/lrc_ttplayer/main.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scripts/lrc_ttplayer/script.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119659/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/c0d77a2e-462b-4e3f-be70-8d3aa6762ad7__gsocFullDiff_v1.patch">diff to use for testing</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>