<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112199/">https://git.reviewboard.kde.org/r/112199/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4e254c6107166ddf0838990e908dc885dad8f1ba by Vedant Agarwala on behalf of Frank Meerkoetter to branch tagguessing.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On August 25th, 2013, 8:40 a.m. UTC, Frank Meerkoetter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2013, 8:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=313504">313504</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixing a number of issues from
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
13. Check for foreach loop issues [foreach]...
[...]
Prefer a const reference over a copy. This patch is only a first batch - fixing the simple cases.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All unit tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/TagsFromFileNameGuesser.cpp <span style="color: grey">(0ae8dbd)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(99adb53)</span></li>
<li>src/OpmlParser.cpp <span style="color: grey">(e47e103)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.cpp <span style="color: grey">(5701d77)</span></li>
<li>src/context/applets/labels/LabelsApplet.cpp <span style="color: grey">(f5bc55d)</span></li>
<li>src/core-impl/collections/daap/DaapCollection.cpp <span style="color: grey">(20e7b4f)</span></li>
<li>src/core-impl/collections/daap/daapreader/Reader.cpp <span style="color: grey">(a80922c)</span></li>
<li>src/core-impl/collections/db/MountPointManager.cpp <span style="color: grey">(dc74896)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.cpp <span style="color: grey">(c11a6bd)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp <span style="color: grey">(7ecdcfa)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp <span style="color: grey">(ff9e4ad)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp <span style="color: grey">(b699b6e)</span></li>
<li>src/core-impl/collections/ipodcollection/support/IphoneMountPoint.cpp <span style="color: grey">(2926e77)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Query.cpp <span style="color: grey">(29619a9)</span></li>
<li>src/core-impl/collections/support/CollectionManager.cpp <span style="color: grey">(db5c984)</span></li>
<li>src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp <span style="color: grey">(7579ba2)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp <span style="color: grey">(6467964)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp <span style="color: grey">(80ea8de)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQuery.cpp <span style="color: grey">(e945bfd)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp <span style="color: grey">(67e153f)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp <span style="color: grey">(c77f920)</span></li>
<li>src/core-impl/meta/cue/CueFileSupport.cpp <span style="color: grey">(77d27e6)</span></li>
<li>src/core/transcoding/TranscodingConfiguration.cpp <span style="color: grey">(dbcd0b3)</span></li>
<li>src/core/transcoding/formats/TranscodingAacFormat.cpp <span style="color: grey">(2b0a02c)</span></li>
<li>src/core/transcoding/formats/TranscodingFlacFormat.cpp <span style="color: grey">(fd8a832)</span></li>
<li>src/core/transcoding/formats/TranscodingMp3Format.cpp <span style="color: grey">(83d0e2f)</span></li>
<li>src/core/transcoding/formats/TranscodingOpusFormat.cpp <span style="color: grey">(3ee991b)</span></li>
<li>src/core/transcoding/formats/TranscodingVorbisFormat.cpp <span style="color: grey">(8c32d69)</span></li>
<li>src/core/transcoding/formats/TranscodingWmaFormat.cpp <span style="color: grey">(d7646d2)</span></li>
<li>src/covermanager/CoverCache.cpp <span style="color: grey">(14a4646)</span></li>
<li>src/databaseimporter/amarok14/FastForwardWorker.cpp <span style="color: grey">(113141d)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(0672421)</span></li>
<li>src/dialogs/OrganizeCollectionDialog.cpp <span style="color: grey">(a29e626)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(3c07fd1)</span></li>
<li>src/network/NetworkAccessViewer.cpp <span style="color: grey">(f5a91dd)</span></li>
<li>src/playlist/layouts/PlaylistLayoutEditDialog.cpp <span style="color: grey">(4211010)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.cpp <span style="color: grey">(b8dd4c4)</span></li>
<li>src/services/lastfm/ScrobblerAdapter.cpp <span style="color: grey">(3c81546)</span></li>
<li>src/services/lastfm/SynchronizationAdapter.cpp <span style="color: grey">(ae4b820)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryView.cpp <span style="color: grey">(feba375)</span></li>
<li>src/statsyncing/Config.cpp <span style="color: grey">(40dc79d)</span></li>
<li>src/transcoding/TranscodingOptionsStackedWidget.cpp <span style="color: grey">(26128d5)</span></li>
<li>src/widgets/FilenameLayoutWidget.cpp <span style="color: grey">(aee4175)</span></li>
<li>utilities/collectionscanner/CollectionScanner.cpp <span style="color: grey">(dd4ae37)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112199/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>