<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116741/">https://git.reviewboard.kde.org/r/116741/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 01b3ab9fd70b158bfc6f4529ce22a671c5d2820c by Daniel Meltzer to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 11th, 2014, 8:45 p.m. UTC, yash ladia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By yash ladia.</div>
<p style="color: grey;"><i>Updated March 11, 2014, 8:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=331934">331934</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have corrected the URL to the new one.
Also, when there was an error in downloading the relatively large (17.3 mb) file, it just used to quit silently. With my patch it still does, but the "update" button becomes enabled so that the download can be attempted again without restarting Amarok. I had to make sure that the 'm_listDownloadJob = 0;' (line 205) was called so I placed it before the return statement. Otherwise, it was giving a segfault error when Amarok was being quit.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jamendo works now. File downloads as expected.
Also, I testing the working of the new update button behavior by running the update without any internet connection. The "update" button became enabled in this case.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/jamendo/JamendoService.cpp <span style="color: grey">(e4a7ecc)</span></li>
<li>src/services/jamendo/JamendoXmlParser.h <span style="color: grey">(6bdc67d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116741/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>