<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113278/">http://git.reviewboard.kde.org/r/113278/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 14th, 2013, 8:50 p.m. UTC, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113278/diff/3/?file=211301#file211301line65" style="color: black; font-weight: bold; text-decoration: underline;">src/configdialog/dialogs/MetadataConfig.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">64</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_synchronizeButton</span><span class="o">-></span><span class="n">setIcon</span><span class="p">(</span> <span class="n">KIcon</span><span class="p">(</span> <span class="s">"amarok_playcount"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_synchronizeButton</span><span class="o">-></span><span class="n">setIcon</span><span class="p">(</span> <span class="n">KIcon</span><span class="p">(</span> <span class="s">"amarok_playcount"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_addTargetButton</span><span class="o">-></span><span class="n">setIcon</span><span class="p">(</span> <span class="n">KIcon</span><span class="p">(</span> <span class="s">"folder-new"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_configureTargetButton</span><span class="o">-></span><span class="n">setIcon</span><span class="p">(</span> <span class="n">KIcon</span><span class="p">(</span> <span class="s">"configure"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just to know: new enough Qt Designer supports setting icons by name - fill in the icon name into icon->Theme field so that it is filled into the .ui file.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I couldn't get configure to show up when set through QtCreator. Both folder-new and edit-clear work, though.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 14th, 2013, 8:50 p.m. UTC, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113278/diff/3/?file=211302#file211302line133" style="color: black; font-weight: bold; text-decoration: underline;">src/configdialog/dialogs/MetadataConfig.ui</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">133</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <widget class="QPushButton" name="m_configureTargetButton"></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">134</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <property name="text"></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">135</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string>Configure</string></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">136</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> </property></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">137</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> </widget></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">138</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> </item></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">139</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <item></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">140</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <widget class="QPushButton" name="m_addTargetButton"></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">141</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <property name="text"></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">142</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string>Add</string></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that KDE Human Interface Guidelines say that buttons that open dialogs should have "..." appended to the label. (but please rather check it)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They do, thanks for pointing it out.
http://techbase.kde.org/Projects/Usability/HIG/Buttons "Indicate a command that needs additional information (including confirmation) by adding an ellipsis at the end of the button label."</pre>
<br />
<p>- Konrad</p>
<br />
<p>On December 10th, 2013, 9:32 p.m. UTC, Konrad Zemek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Konrad Zemek.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2013, 9:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review contains other changes made as a part of my project, i.e. changes
outside of src/statsyncing , src/importers and tests/importers directories.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>images/icons/hi16-action-view-importers-banshee-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi16-action-view-importers-clementine-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi16-action-view-importers-rhythmbox-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi22-action-view-importers-banshee-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi22-action-view-importers-clementine-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi22-action-view-importers-rhythmbox-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi32-action-view-importers-banshee-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi32-action-view-importers-clementine-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi32-action-view-importers-rhythmbox-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi48-action-view-importers-banshee-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi48-action-view-importers-clementine-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>images/icons/hi48-action-view-importers-rhythmbox-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(70fb67b)</span></li>
<li>src/PluginManager.cpp <span style="color: grey">(c48a99b)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.h <span style="color: grey">(72ef69b)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.cpp <span style="color: grey">(7d19f93)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.ui <span style="color: grey">(ff5d332)</span></li>
<li>src/configdialog/dialogs/PluginsConfig.cpp <span style="color: grey">(d5011b8)</span></li>
<li>src/core-impl/collections/support/CollectionManager.h <span style="color: grey">(062418c)</span></li>
<li>src/core/support/PluginFactory.h <span style="color: grey">(8acd354)</span></li>
<li>src/databaseimporter/DatabaseImporter.h <span style="color: grey">(602f332)</span></li>
<li>src/databaseimporter/DatabaseImporter.cpp <span style="color: grey">(00dd895)</span></li>
<li>src/databaseimporter/amarok14/FastForwardImporter.h <span style="color: grey">(76a2519)</span></li>
<li>src/databaseimporter/amarok14/FastForwardImporter.cpp <span style="color: grey">(31e1c3c)</span></li>
<li>src/databaseimporter/amarok14/FastForwardImporterConfig.h <span style="color: grey">(21048c7)</span></li>
<li>src/databaseimporter/amarok14/FastForwardImporterConfig.cpp <span style="color: grey">(e803cf5)</span></li>
<li>src/databaseimporter/amarok14/FastForwardWorker.h <span style="color: grey">(6a4640f)</span></li>
<li>src/databaseimporter/amarok14/FastForwardWorker.cpp <span style="color: grey">(b40b8a3)</span></li>
<li>src/databaseimporter/itunes/ITunesImporter.h <span style="color: grey">(a8b8f54)</span></li>
<li>src/databaseimporter/itunes/ITunesImporter.cpp <span style="color: grey">(5da190e)</span></li>
<li>src/databaseimporter/itunes/ITunesImporterConfig.h <span style="color: grey">(78fe10b)</span></li>
<li>src/databaseimporter/itunes/ITunesImporterConfig.cpp <span style="color: grey">(8aa9733)</span></li>
<li>src/databaseimporter/itunes/ITunesImporterWorker.h <span style="color: grey">(e8a104d)</span></li>
<li>src/databaseimporter/itunes/ITunesImporterWorker.cpp <span style="color: grey">(e7149c8)</span></li>
<li>src/databaseimporter/sqlbatch/SqlBatchImporter.h <span style="color: grey">(f233652)</span></li>
<li>src/databaseimporter/sqlbatch/SqlBatchImporter.cpp <span style="color: grey">(79bcd0c)</span></li>
<li>src/databaseimporter/sqlbatch/SqlBatchImporterConfig.h <span style="color: grey">(fab735c)</span></li>
<li>src/databaseimporter/sqlbatch/SqlBatchImporterConfig.cpp <span style="color: grey">(26b68d4)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(2b120e3)</span></li>
<li>src/dialogs/DatabaseImporterDialog.h <span style="color: grey">(f0ae7c3)</span></li>
<li>src/dialogs/DatabaseImporterDialog.cpp <span style="color: grey">(5159ce8)</span></li>
<li>src/services/lastfm/SynchronizationTrack.h <span style="color: grey">(d6fb593)</span></li>
<li>src/services/lastfm/SynchronizationTrack.cpp <span style="color: grey">(39c51d4)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(e18aaa1)</span></li>
<li>tests/CollectionTestImpl.h <span style="color: grey">(183c3c2)</span></li>
<li>tests/mocks/MetaMock.h <span style="color: grey">(37a50ce)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113278/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>