<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113666/">http://git.reviewboard.kde.org/r/113666/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 18th, 2013, 12:49 a.m. CET, <b>Edward Toroshchin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113666/diff/1/?file=210110#file210110line52" style="color: black; font-weight: bold; text-decoration: underline;">cmake/modules/FindMtp.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">message</span><span class="p">(</span><span class="s">STATUS</span> <span class="s2">"Found MTP but version requirements not met"</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">message</span><span class="p">(</span><span class="s">STATUS</span> <span class="s2">"Found MTP but version requirements <span class="hl">(${MTP_MIN_VERSION}) </span>not met"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The wording is a bit convoluted.
Probably something like "Found MTP, but we want at least version ${MTP_MIN_VERSION}" would be better.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How about: "Found MTP, but version ${MTP_MIN_VERSION} is needed"</pre>
<br />
<p>- Myriam</p>
<br />
<p>On November 6th, 2013, 12:34 a.m. CET, Matěj Laitl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matěj Laitl.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2013, 12:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my full GSoC project to rewrite MTP collection.
Notes:
* Individual commits can be seen at http://quickgit.kde.org/?p=clones%2Famarok%2Flaitl%2Famarok.git&a=shortlog&h=gsoc
* First commit to remove the old implementation is not included here for brevity
* Project description can be seen at https://google-melange.appspot.com/gsoc/project/google/gsoc2013/strohel/32001
* More info, progress reports and final report available at http://strohel.blogspot.com/search/label/gsoc</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works well with my Samsung Android 4.1 phone; testing with greater variety of devices needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindMtp.cmake <span style="color: grey">(a6b7a0e)</span></li>
<li>src/core-impl/collections/CMakeLists.txt <span style="color: grey">(4785158)</span></li>
<li>src/core-impl/collections/mtp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/MtpCollection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/MtpCollection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/MtpCollectionFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/MtpCollectionFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/MtpCollectionLocation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/MtpCollectionLocation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/TODO <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/amarok-mtp-manage-music.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/amarok_collection-mtp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/CopyMtpTracksJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/CopyMtpTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/DeleteMtpTracksJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/DeleteMtpTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/DownloadMtpTrackJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/DownloadMtpTrackJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/InitMtpDeviceJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/InitMtpDeviceJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/ListMtpStorageJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/ListMtpStorageJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/MtpTransferJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/MtpTransferJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/ParseMtpTracksJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/ParseMtpTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/SetMtpDeviceNameJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/SetMtpDeviceNameJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/UpdateMtpTrackJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/UpdateMtpTrackJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/UploadMtpTrackJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/jobs/UploadMtpTrackJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/meta/MtpAlbum.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/meta/MtpAlbum.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/meta/MtpEntity.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/meta/MtpTrack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/meta/MtpTrack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/MtpDeviceConfiguration.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/MtpHelpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/MtpHelpers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/MtpTranscodeCapability.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/MtpTranscodeCapability.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/MtpTransferJanitor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/MtpTransferJanitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/OneToOneMap.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/OneToOneMap.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/mtp/support/forward_declarations.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>