<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113272/">http://git.reviewboard.kde.org/r/113272/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 5th, 2013, 11:48 p.m. UTC, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm starring at Diff v2 and either:
1. I'm a fool
2. ReviewBoard fools me (actually rather probable)
3. You uploaded a diff between old part 1 and new part 1, not the complete new part 1.
I'm sorry it took too long for me just to realize this.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, the 3rd scenario is definitely what happened. I'm uploading the diffs manually (I can't figure out how to split review using rb-tools), and I just assumed that diff between previous revision and the next one is what it wants from me.
I actually didn't realize anything either, and I looked through the review after uploading.</pre>
<br />
<p>- Konrad</p>
<br />
<p>On November 6th, 2013, 7:19 p.m. UTC, Konrad Zemek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Konrad Zemek.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2013, 7:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These are changes in the StatSyncing framework that I made as a part of my project.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/statsyncing/Config.h <span style="color: grey">(140e647)</span></li>
<li>src/statsyncing/Config.cpp <span style="color: grey">(dd82dbe)</span></li>
<li>src/statsyncing/Controller.h <span style="color: grey">(10c72a8)</span></li>
<li>src/statsyncing/Controller.cpp <span style="color: grey">(bf4c5d8)</span></li>
<li>src/statsyncing/Provider.h <span style="color: grey">(d9663f9)</span></li>
<li>src/statsyncing/Provider.cpp <span style="color: grey">(775fce3)</span></li>
<li>src/statsyncing/ProviderFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ProviderFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/SimpleTrack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/SimpleTrack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/SimpleWritableTrack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/SimpleWritableTrack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Track.h <span style="color: grey">(2f91704)</span></li>
<li>src/statsyncing/Track.cpp <span style="color: grey">(9655cc1)</span></li>
<li>src/statsyncing/TrackTuple.h <span style="color: grey">(157d604)</span></li>
<li>src/statsyncing/TrackTuple.cpp <span style="color: grey">(9442794)</span></li>
<li>src/statsyncing/jobs/SynchronizeTracksJob.cpp <span style="color: grey">(b789aa3)</span></li>
<li>src/statsyncing/ui/ConfigureProviderDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ConfigureProviderDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/CreateProviderDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/CreateProviderDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113272/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>