<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113356/">http://git.reviewboard.kde.org/r/113356/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2013, 12:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes made as part of my GSoC project.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(fa1ab0c)</span></li>
<li>cmake/modules/FindQtScriptQtBindings.cmake <span style="color: grey">(bd24328)</span></li>
<li>cmake/modules/bindingstest/QtScriptBindingsTest.cpp <span style="color: grey">(424556f)</span></li>
<li>shared/MetaTagLib.h <span style="color: grey">(2de3be2)</span></li>
<li>shared/MetaTagLib.cpp <span style="color: grey">(d42dd32)</span></li>
<li>shared/MetaValues.h <span style="color: grey">(4b003ed)</span></li>
<li>shared/tag_helpers/APETagHelper.cpp <span style="color: grey">(ba39a10)</span></li>
<li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: grey">(3439845)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.h <span style="color: grey">(a9c9ab9)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey">(03a3836)</span></li>
<li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: grey">(23d8879)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(8ff52c5)</span></li>
<li>src/App.h <span style="color: grey">(9ee071d)</span></li>
<li>src/App.cpp <span style="color: grey">(eb3f483)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(70fb67b)</span></li>
<li>src/EngineController.h <span style="color: grey">(80ec17b)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(cf29cf8)</span></li>
<li>src/ScriptManager.h <span style="color: grey">(1a252ca)</span></li>
<li>src/ScriptManager.cpp <span style="color: grey">(04b8eef)</span></li>
<li>src/ScriptUpdater.h <span style="color: grey">(0e9b37d)</span></li>
<li>src/ScriptUpdater.cpp <span style="color: grey">(f174248)</span></li>
<li>src/amarokconfig.kcfg <span style="color: grey">(84cfa5b)</span></li>
<li>src/amarokurls/BookmarkGroup.h <span style="color: grey">(ea42c30)</span></li>
<li>src/browsers/CollectionTreeItem.h <span style="color: grey">(0a5d197)</span></li>
<li>src/browsers/CollectionTreeItem.cpp <span style="color: grey">(4c35523)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.h <span style="color: grey">(00e99fb)</span></li>
<li>src/browsers/CollectionTreeView.h <span style="color: grey">(454a70d)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: grey">(6fad164)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.h <span style="color: grey">(7480015)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: grey">(95a16dc)</span></li>
<li>src/configdialog/dialogs/ScriptSelector.h <span style="color: grey">(9ce1168)</span></li>
<li>src/configdialog/dialogs/ScriptSelector.cpp <span style="color: grey">(117cedf)</span></li>
<li>src/configdialog/dialogs/ScriptsConfig.h <span style="color: grey">(6a47847)</span></li>
<li>src/configdialog/dialogs/ScriptsConfig.cpp <span style="color: grey">(714b63e)</span></li>
<li>src/configdialog/dialogs/ScriptsConfig.ui <span style="color: grey">(b4b8d37)</span></li>
<li>src/context/applets/lyrics/LyricsApplet.cpp <span style="color: grey">(7db356d)</span></li>
<li>src/context/applets/songkick/SongkickApplet.cpp <span style="color: grey">(ed93e56)</span></li>
<li>src/context/engines/lyrics/LyricsEngine.cpp <span style="color: grey">(d3273b0)</span></li>
<li>src/core-impl/collections/support/jobs/WriteTagsJob.h <span style="color: grey">(a92ab8d)</span></li>
<li>src/core-impl/collections/support/jobs/WriteTagsJob.cpp <span style="color: grey">(5834cd4)</span></li>
<li>src/core/collections/Collection.h <span style="color: grey">(94d24d7)</span></li>
<li>src/core/collections/QueryMaker.h <span style="color: grey">(92b6a65)</span></li>
<li>src/core/meta/support/MetaConstants.cpp <span style="color: grey">(40d7122)</span></li>
<li>src/dialogs/DiagnosticDialog.cpp <span style="color: grey">(c9bfce6)</span></li>
<li>src/dialogs/EqualizerDialog.h <span style="color: grey">(6c9e19e)</span></li>
<li>src/dialogs/EqualizerDialog.cpp <span style="color: grey">(acf0da0)</span></li>
<li>src/dialogs/deviceconfiguredialog.cpp <span style="color: grey">(e54edad)</span></li>
<li>src/dynamic/BiasFactory.cpp <span style="color: grey">(2a887c2)</span></li>
<li>src/dynamic/TrackSet.h <span style="color: grey">(dee8ee3)</span></li>
<li>src/dynamic/TrackSet.cpp <span style="color: grey">(456a10a)</span></li>
<li>src/equalizer/EqualizerPresets.h <span style="color: grey">(be8d267)</span></li>
<li>src/equalizer/EqualizerPresets.cpp <span style="color: grey">(b9aa13b)</span></li>
<li>src/playback/EqualizerController.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playback/EqualizerController.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlistmanager/PlaylistManager.h <span style="color: grey">(a835c35)</span></li>
<li>src/scriptengine/AmarokCollectionScript.h <span style="color: grey">(224bd54)</span></li>
<li>src/scriptengine/AmarokCollectionScript.cpp <span style="color: grey">(3fcda84)</span></li>
<li>src/scriptengine/AmarokEngineScript.h <span style="color: grey">(aa2b112)</span></li>
<li>src/scriptengine/AmarokEngineScript.cpp <span style="color: grey">(5471838)</span></li>
<li>src/scriptengine/AmarokInfoScript.h <span style="color: grey">(754498e)</span></li>
<li>src/scriptengine/AmarokInfoScript.cpp <span style="color: grey">(4d06568)</span></li>
<li>src/scriptengine/AmarokKNotifyScript.h <span style="color: grey">(720f9f6)</span></li>
<li>src/scriptengine/AmarokKNotifyScript.cpp <span style="color: grey">(b98efed)</span></li>
<li>src/scriptengine/AmarokLyricsScript.h <span style="color: grey">(a47c609)</span></li>
<li>src/scriptengine/AmarokLyricsScript.cpp <span style="color: grey">(b1972fa)</span></li>
<li>src/scriptengine/AmarokNetworkScript.h <span style="color: grey">(785a645)</span></li>
<li>src/scriptengine/AmarokNetworkScript.cpp <span style="color: grey">(0eaa440)</span></li>
<li>src/scriptengine/AmarokOSDScript.h <span style="color: grey">(992fcee)</span></li>
<li>src/scriptengine/AmarokOSDScript.cpp <span style="color: grey">(659cd68)</span></li>
<li>src/scriptengine/AmarokPlaylistScript.h <span style="color: grey">(a9df74e)</span></li>
<li>src/scriptengine/AmarokPlaylistScript.cpp <span style="color: grey">(2dde634)</span></li>
<li>src/scriptengine/AmarokScript.h <span style="color: grey">(4ec6d8f)</span></li>
<li>src/scriptengine/AmarokScript.cpp <span style="color: grey">(b21a2ec)</span></li>
<li>src/scriptengine/AmarokScriptConfig.h <span style="color: grey">(a77418f)</span></li>
<li>src/scriptengine/AmarokScriptConfig.cpp <span style="color: grey">(457104a)</span></li>
<li>src/scriptengine/AmarokScriptableServiceScript.h <span style="color: grey">(6afacfa)</span></li>
<li>src/scriptengine/AmarokScriptableServiceScript.cpp <span style="color: grey">(a312671)</span></li>
<li>src/scriptengine/AmarokServicePluginManagerScript.h <span style="color: grey">(ed7f307)</span></li>
<li>src/scriptengine/AmarokServicePluginManagerScript.cpp <span style="color: grey">(86f841c)</span></li>
<li>src/scriptengine/AmarokStatusbarScript.h <span style="color: grey">(c871213)</span></li>
<li>src/scriptengine/AmarokStatusbarScript.cpp <span style="color: grey">(6efbb38)</span></li>
<li>src/scriptengine/AmarokWindowScript.h <span style="color: grey">(5b18e18)</span></li>
<li>src/scriptengine/AmarokWindowScript.cpp <span style="color: grey">(c9a65ee)</span></li>
<li>src/scriptengine/MetaTypeExporter.h <span style="color: grey">(ec961e8)</span></li>
<li>src/scriptengine/MetaTypeExporter.cpp <span style="color: grey">(d832181)</span></li>
<li>src/scriptengine/ScriptImporter.h <span style="color: grey">(7ae9155)</span></li>
<li>src/scriptengine/ScriptImporter.cpp <span style="color: grey">(672cd24)</span></li>
<li>src/scripting/scriptconsole/CompletionModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/CompletionModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptConsole.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptConsole.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptConsoleItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptConsoleItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptEditorDocument.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptEditorDocument.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokBookmarkScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokBookmarkScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokCollectionScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokCollectionViewScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokCollectionViewScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokEqualizerScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokEqualizerScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokNetworkScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokPlaylistManagerScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokPlaylistManagerScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokPlaylistScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokScriptableServiceScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokStreamItemScript.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokStreamItemScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/AmarokWindowScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/PHAACG2.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/ScriptingDefines.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/ScriptingDefines.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/CollectionTypeExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/CollectionTypeExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/MetaTypeExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/MetaTypeExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/PlaylistExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/PlaylistExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/PlaylistProviderExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/PlaylistProviderExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/QueryMakerExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/QueryMakerExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/ScriptableBiasExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptengine/exporters/ScriptableBiasExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptmanager/ScriptItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptmanager/ScriptItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripts/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/scripts/ScriptWriting-HOWTO <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/COPYING <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/LibrivoxEmblem.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/LibrivoxIcon.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/LibrivoxLogo.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/LibrivoxScalableEmblem.svgz <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/LibrivoxService.html <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/README <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/audio_book.svgz <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/audio_book128.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/audio_book16.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/audio_book22.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/audio_book32.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/audio_book48.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/audio_book64.png <span style="color: grey">()</span></li>
<li>src/scripts/librivox_service/main.js <span style="color: grey">(06035af)</span></li>
<li>src/scripts/librivox_service/script.spec <span style="color: grey">(26719d5)</span></li>
<li>src/scripts/lyrics_lyricwiki/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/scripts/lyrics_lyricwiki/main.js <span style="color: grey">(08a3701)</span></li>
<li>src/scripts/lyrics_lyricwiki/script.spec <span style="color: grey">(d3346dc)</span></li>
<li>src/scripts/qtscript_debug/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/scripts/qtscript_debug/debug/debug.js <span style="color: grey">()</span></li>
<li>src/scripts/qtscript_debug/main.js <span style="color: grey">()</span></li>
<li>src/scripts/qtscript_debug/script.spec <span style="color: grey">()</span></li>
<li>src/scripts/radio_station_service/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/scripts/radio_station_service/main.js <span style="color: grey">()</span></li>
<li>src/scripts/radio_station_service/script.spec <span style="color: grey">()</span></li>
<li>src/scripts/script_console/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/scripts/script_console/main.js <span style="color: grey">()</span></li>
<li>src/scripts/script_console/script.spec <span style="color: grey">()</span></li>
<li>src/scripts/templates/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/scripts/templates/script.spec <span style="color: grey">()</span></li>
<li>src/scripts/templates/template.js <span style="color: grey">()</span></li>
<li>src/scripts/webcontrol/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/scripts/webcontrol/main.js <span style="color: grey">()</span></li>
<li>src/scripts/webcontrol/script.spec <span style="color: grey">()</span></li>
<li>src/services/scriptable/ScriptableService.cpp <span style="color: grey">(f254e3e)</span></li>
<li>src/services/scriptable/ScriptableServiceInfoParser.cpp <span style="color: grey">(998135b)</span></li>
<li>src/services/scriptable/ScriptableServiceManager.cpp <span style="color: grey">(aa28a6c)</span></li>
<li>src/services/scriptable/ScriptableServiceQueryMaker.cpp <span style="color: grey">(07233dd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113356/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>