<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113346/">http://git.reviewboard.kde.org/r/113346/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 19th, 2013, 7:49 p.m. CEST, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113346/diff/3/?file=203475#file203475line41" style="color: black; font-weight: bold; text-decoration: underline;">src/core-impl/collections/support/CollectionLocationDelegateImpl.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="n">Transcoding</span><span class="o">::</span><span class="n">Configuration</span> <span class="n">transcode</span><span class="p">(</span> <span class="k">const</span> <span class="n">QStringList</span> <span class="o">&</span><span class="n">playableFileTypes</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="n">Transcoding</span><span class="o">::</span><span class="n">Configuration</span> <span class="n">transcode</span><span class="p">(</span><span class="k">const</span> <span class="n">QStringList</span> <span class="o">&</span><span class="n">playableFileTypes</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="o">*</span><span class="n">remember</span><span class="p">,</span> <span class="n">OperationType</span> <span class="n">operation</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="o">*</span><span class="n">remember</span><span class="p">,</span> <span class="kt"><span class="hl">bool</span></span><span class="hl"> </span><span class="n"><span class="hl">isEncoderAvailable</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n">OperationType</span> <span class="n">operation</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TranscodingAssistantDialog knows what encoders are available (see its populateFormatList() method), no need to pass this as an argument. Also, please mind Amarok coding style (space between "transcode(" and "const")</pre>
</blockquote>
<p>On October 19th, 2013, 8:32 p.m. CEST, <b>Jai Luthra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Inside populateFormatList(), if available.isEmpty(), I think I should call (and define) another method TranscodingAssistantDialog::encoderNotFound() rather than changing the UI from the if block itself. Right?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's up to you, the code to show the warning is simple, no problem with embedding it into populateFormatList().
Another idea: add "You may check <i>%1</i> in order to skip this dialog for future transfers" - where %1 is text of the checkbox button to do this. (please do it this way to ensure that the text is exactly the same even in translations)</pre>
<br />
<p>- Matěj</p>
<br />
<p>On October 19th, 2013, 11:12 a.m. CEST, Jai Luthra wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Jai Luthra.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2013, 11:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=317902">317902</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When ffmpeg is not available, the transcoding dialog will not be skipped; rather it will add a note for the user to install an encoder.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Compiles
* Works as expected</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/support/CollectionLocationDelegateImpl.h <span style="color: grey">(9d90580)</span></li>
<li>src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp <span style="color: grey">(14fd251)</span></li>
<li>src/core/collections/CollectionLocation.cpp <span style="color: grey">(2385570)</span></li>
<li>src/core/collections/CollectionLocationDelegate.h <span style="color: grey">(3c80d07)</span></li>
<li>src/transcoding/TranscodingAssistantDialog.h <span style="color: grey">(0acb701)</span></li>
<li>src/transcoding/TranscodingAssistantDialog.cpp <span style="color: grey">(17fc250)</span></li>
<li>src/transcoding/TranscodingAssistantDialog.ui <span style="color: grey">(0ad83b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113346/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>