<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113272/">http://git.reviewboard.kde.org/r/113272/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 18th, 2013, 10 a.m. UTC, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113272/diff/1/?file=201959#file201959line39" style="color: black; font-weight: bold; text-decoration: underline;">src/statsyncing/Config.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace StatSyncing</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ProviderIdRole</span> <span class="o">=</span> <span class="n">Qt</span><span class="o">::</span><span class="n">UserRole</span><span class="p"><span class="hl">,</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ProviderIdRole</span> <span class="o">=</span> <span class="n">Qt</span><span class="o">::</span><span class="n">UserRole</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess the ability have an extra comma is a g++ extension to C++, right? Only thing I like about it is clearer diff when adding new values - but that's just cosmetic.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">C++11 and C99 actually allow the trailing comma.</pre>
<br />
<p>- Edward Hades</p>
<br />
<p>On October 16th, 2013, 5:11 p.m. UTC, Konrad Zemek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Konrad Zemek.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2013, 5:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These are changes in the StatSyncing framework that I made as a part of my project.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/statsyncing/Config.h <span style="color: grey">(140e647ecbcd6edd11cbe637a3e7b482bd24ec70)</span></li>
<li>src/statsyncing/Config.cpp <span style="color: grey">(dd82dbe7729bf1b8cc2f5153c8af39aade0a9b81)</span></li>
<li>src/statsyncing/Controller.h <span style="color: grey">(10c72a809d1cb7065363a978df6aa2561621de2a)</span></li>
<li>src/statsyncing/Controller.cpp <span style="color: grey">(bf4c5d8324bce796cf9b0057d21721b20af700b5)</span></li>
<li>src/statsyncing/Provider.h <span style="color: grey">(d9663f93073de3035eb609967adea491f8192ab9)</span></li>
<li>src/statsyncing/Provider.cpp <span style="color: grey">(775fce388248b8e7aca1af442714d26549d014ce)</span></li>
<li>src/statsyncing/Track.h <span style="color: grey">(2f917045371d8caab3ec48d37050dfa5cec15f18)</span></li>
<li>src/statsyncing/Track.cpp <span style="color: grey">(9655cc16078724f5aa4f1dde532c1b65f2e574c1)</span></li>
<li>src/statsyncing/TrackTuple.h <span style="color: grey">(157d6044c1c7c79f471b9059f6a812887fa730ac)</span></li>
<li>src/statsyncing/TrackTuple.cpp <span style="color: grey">(944279414ab82ff811b33e1de0cd0f73f623d23b)</span></li>
<li>src/statsyncing/jobs/SynchronizeTracksJob.cpp <span style="color: grey">(b789aa32314b345270c07b34823e82b2a74ed6dd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113272/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>