<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113277/">http://git.reviewboard.kde.org/r/113277/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A minor note: I am sure that the binary MySQL files will not work across all the possible environments. They might stop working even from a minor version difference (5.1 vs 5.2), but they will definitely fail across platform boundaries (32 vs 64).
But I think we can handle this later.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113277/diff/1/?file=202043#file202043line11" style="color: black; font-weight: bold; text-decoration: underline;">Library.xml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><key>Music Folder</key><string>file://localhost/C:/Documents%20and%20Settings/Konrad/My%20Documents/My%20Music/iTunes/iTunes%20Media/</string></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><key>Library Persistent ID</key><string>16428B78086CAFA8</string></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Probably you should remove private data, like directory path and library ID.</pre>
</div>
<br />
<p>- Edward Hades Toroshchin</p>
<br />
<p>On October 16th, 2013, 5:11 p.m. UTC, Konrad Zemek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Konrad Zemek.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2013, 5:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review contains importers tests.
The tests/importers/TestImporterBase.cpp contains common tests for concrete
importers. The tests load a prepared database and read it through the importer.
It's therefore important that the prepared database contain certain data.
The tests/importers/files/testCollection directory contains very small mp3
files that are *not* used as a part of the tests, and instead are meant for
creating the test database: one would just import these files into a media
player, copy the media player's database and have it instantly ready for
the common tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Music <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/ImporterMocks.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/ImporterMocks.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestAmarokImporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestAmarokImporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestBansheeImporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestBansheeImporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestClementineImporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestClementineImporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestFastForwardImporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestFastForwardImporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestITunesImporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestITunesImporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestImporterBase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestImporterBase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestImporterManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestImporterManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestImporterProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestImporterProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestRhythmboxImporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestRhythmboxImporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestSimpleImporterConfigWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/TestSimpleImporterConfigWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/banshee.db <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/clementine.db <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/collection.db <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/illFormedLibrary.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/admin.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/admin.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/admin.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/albums.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/albums.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/albums.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/amazon.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/amazon.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/artists.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/artists.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/artists.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/bookmark_groups.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/bookmark_groups.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/bookmarks.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/bookmarks.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/composers.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/composers.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/composers.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/db.opt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/devices.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/devices.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/devices.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/directories.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/directories.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/directories.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/genres.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/genres.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/genres.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/images.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/images.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/labels.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/labels.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/labels.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/lyrics.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/lyrics.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/playlist_groups.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/playlist_groups.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/playlist_tracks.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/playlist_tracks.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/playlists.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/playlists.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/podcastchannels.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/podcastchannels.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/podcastepisodes.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/podcastepisodes.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/statistics.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/statistics.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/statistics.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/statistics_permanent.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/statistics_permanent.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/statistics_tag.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/statistics_tag.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/tracks.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/tracks.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/tracks.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/urls.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/urls.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/urls.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/urls_labels.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/urls_labels.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/urls_labels.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/years.MYD <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/years.MYI <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/amarok/years.frm <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/aria_log.00000001 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/mysqle/aria_log_control <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/rhythmdb.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/albumUnset.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveAlbum1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveAlbum2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveAlbum3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveArtist1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveArtist2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveArtist3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveComposer1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveComposer2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveComposer3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveTitle1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveTitle2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/caseSensitiveTitle3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/composerUnset.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/discUnset.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/multiWordAlbum.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/multiWordArtist.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/multiWordComposer.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/multiWordTitle.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics0.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics4.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics5.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics6.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics7.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics8.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatistics9.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet0.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet4.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet5.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet6.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet7.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet8.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/testStatisticsNotSet9.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trackUnset.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimAlbum1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimAlbum2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimAlbum3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimArtist1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimArtist2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimArtist3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimComposer1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimComposer2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimComposer3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimTitle1.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimTitle2.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/trimTitle3.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/utfAlbum.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/utfArtist.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/utfComposer.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/utfTitle.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/importers/files/testcollection/yearUnset.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113277/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>