<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112802/">http://git.reviewboard.kde.org/r/112802/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 18th, 2013, 9:46 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm torn between following Amarok's internals (which you do) and following MPRIS2, meaning it should be called UserRating and return/allow a double between 0.0 and 1.0.
There's also the question of how urgent this is, as there's discussion on the MPRIS list (which had stalled for a few months, but I started up again) about adding a general way of editing Metadata entries.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't see anyy sign of UserRating in MPRIS2 specs: http://specifications.freedesktop.org/mpris-spec/latest/... Can you point me to the right place? If there is a more standard way to set rating, I would prefer doing it that way.
A general way of editing metadata would be great, but would it not be better to handle rating differently (e.g. standardize range 0.0 ... 1.0 and let applications map their understanding of rating into that range)?</pre>
<br />
<p>- Alex</p>
<br />
<p>On September 18th, 2013, 7:34 p.m. UTC, Alex Busenius wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Alex Merry.</div>
<div>By Alex Busenius.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2013, 7:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The D-Bus interface is currently missing convenient method for reading and setting user rating (the stars). The proposed patch adds an Mpris2 extension to /org/mpris/MediaPlayer2 for that:
property readwrite int org.kde.amarok.Mpris2Extensions.Player.Rating</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dbus/mpris2/MediaPlayer2AmarokExtensions.h <span style="color: grey">(964c7b8)</span></li>
<li>src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp <span style="color: grey">(ba8b54e)</span></li>
<li>src/dbus/mpris2/org.kde.amarok.Mpris2Extensions.Player.xml <span style="color: grey">(3397df4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112802/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>