<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112248/">http://git.reviewboard.kde.org/r/112248/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QLatin1String is more efficient.
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
33: Check for strings used improperly or should be i18n. [strings]...OOPS! 78 issues found!
[...]
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests pass.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=313504">313504</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(7528a77)</span></li>
<li>src/MediaDeviceCache.cpp <span style="color: grey">(73e8f34)</span></li>
<li>src/ScriptManager.cpp <span style="color: grey">(4b4fc14)</span></li>
<li>src/amarokurls/NavigationUrlGenerator.cpp <span style="color: grey">(0456976)</span></li>
<li>src/amarokurls/NavigationUrlRunner.cpp <span style="color: grey">(bde18e5)</span></li>
<li>src/context/applets/info/InfoApplet.cpp <span style="color: grey">(760b241)</span></li>
<li>src/context/engines/similarartists/SimilarArtistsEngine.cpp <span style="color: grey">(898beb4)</span></li>
<li>src/context/engines/tabs/TabsEngine.cpp <span style="color: grey">(24a89df)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdCollection.cpp <span style="color: grey">(3dfa7c3)</span></li>
<li>src/core-impl/collections/daap/DaapCollection.cpp <span style="color: grey">(20e7b4f)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(b399ed3)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp <span style="color: grey">(7ecdcfa)</span></li>
<li>src/core-impl/collections/support/ArtistHelper.cpp <span style="color: grey">(4c3f742)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: grey">(ad38461)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp <span style="color: grey">(6467964)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp <span style="color: grey">(80ea8de)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.cpp <span style="color: grey">(9b660de)</span></li>
<li>src/core-impl/meta/cue/CueFileSupport.cpp <span style="color: grey">(77d27e6)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(f2abea4)</span></li>
<li>src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp <span style="color: grey">(28e3b00)</span></li>
<li>src/core/support/Amarok.cpp <span style="color: grey">(ca59725)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(0672421)</span></li>
<li>src/services/amazon/AmazonStore.cpp <span style="color: grey">(eb42566)</span></li>
<li>src/services/ampache/AmpacheAccountLogin.cpp <span style="color: grey">(26aebed)</span></li>
<li>src/services/ampache/AmpacheServiceQueryMaker.cpp <span style="color: grey">(b94c3b0)</span></li>
<li>src/services/lastfm/ScrobblerAdapter.cpp <span style="color: grey">(3c81546)</span></li>
<li>src/services/magnatune/MagnatuneSqlCollection.cpp <span style="color: grey">(2f50e90)</span></li>
<li>src/services/mp3tunes/Mp3tunesWorkers.cpp <span style="color: grey">(a7ebd36)</span></li>
<li>src/statsyncing/collection/CollectionProvider.cpp <span style="color: grey">(a26cec6)</span></li>
<li>src/widgets/Osd.cpp <span style="color: grey">(32c46e9)</span></li>
<li>supplementary_scripts/licenseChecker/log.cpp <span style="color: grey">(ba9b0fd)</span></li>
<li>supplementary_scripts/licenseChecker/main.cpp <span style="color: grey">(4e6bba8)</span></li>
<li>tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp <span style="color: grey">(ab41db3)</span></li>
<li>tests/core-impl/support/TestTrackLoader.cpp <span style="color: grey">(ce369e2)</span></li>
<li>utilities/afttagger/AFTTagger.cpp <span style="color: grey">(5a60c6b)</span></li>
<li>utilities/amzdownloader/AmzDownloader.cpp <span style="color: grey">(e6771de)</span></li>
<li>utilities/collectionscanner/CollectionScanner.cpp <span style="color: grey">(dd4ae37)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112248/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>