<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112148/">http://git.reviewboard.kde.org/r/112148/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prefer QChar overloads over the QString ones for efficiency
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
7. Check single-char QString operations for efficiency [doublequote_chars]...OOPS! 60 issues found!
[...]</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/TagsFromFileNameGuesser.cpp <span style="color: grey">(f2ec2ba)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(70afbb2)</span></li>
<li>src/amarokurls/ContextUrlRunner.cpp <span style="color: grey">(05719ed)</span></li>
<li>src/browsers/filebrowser/FileBrowser.cpp <span style="color: grey">(82dad74)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp <span style="color: grey">(e631de2)</span></li>
<li>src/context/applets/labels/LabelsApplet.cpp <span style="color: grey">(a3f80fb)</span></li>
<li>src/context/applets/tabs/TabsView.cpp <span style="color: grey">(fc11c4a)</span></li>
<li>src/context/engines/lyrics/LyricsEngine.cpp <span style="color: grey">(a65be19)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollection.cpp <span style="color: grey">(c420e35)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.cpp <span style="color: grey">(1e20535)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(fd464cb)</span></li>
<li>src/core-impl/collections/db/sql/SqlRegistry_p.cpp <span style="color: grey">(21b9d45)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp <span style="color: grey">(2cdd10a)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCache.cpp <span style="color: grey">(21f8264)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp <span style="color: grey">(ead5d79)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(73192a8)</span></li>
<li>src/core/podcasts/PodcastImageFetcher.cpp <span style="color: grey">(afd4929)</span></li>
<li>src/dialogs/TagGuesser.cpp <span style="color: grey">(deb403f)</span></li>
<li>src/dynamic/DynamicModel.cpp <span style="color: grey">(201cc93)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(6892232)</span></li>
<li>src/network/NetworkAccessManagerProxy.cpp <span style="color: grey">(a2694bf)</span></li>
<li>src/playlist/PlaylistModel.cpp <span style="color: grey">(e93bd06)</span></li>
<li>src/playlist/PlaylistSortWidget.cpp <span style="color: grey">(bc25b1b)</span></li>
<li>src/playlist/proxymodels/ProxyBase.cpp <span style="color: grey">(47d36f4)</span></li>
<li>src/playlistgenerator/constraints/TagMatch.cpp <span style="color: grey">(d53ca53)</span></li>
<li>src/services/jamendo/JamendoDatabaseHandler.cpp <span style="color: grey">(1e7dc2d)</span></li>
<li>src/services/lastfm/biases/WeeklyTopBias.cpp <span style="color: grey">(c99c538)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(7ae9373)</span></li>
<li>src/widgets/ProgressWidget.cpp <span style="color: grey">(82ff9bf)</span></li>
<li>tests/TestDebug.cpp <span style="color: grey">(c9ff0bb)</span></li>
<li>tests/TestTrackOrganizer.cpp <span style="color: grey">(ffcec68)</span></li>
<li>tests/browsers/TestSingleCollectionTreeItemModel.cpp <span style="color: grey">(dbd3ada)</span></li>
<li>tests/context/engines/TestDataEngineBlackBox.cpp <span style="color: grey">(a9b83e9)</span></li>
<li>tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp <span style="color: grey">(c4522c8)</span></li>
<li>tests/core-impl/collections/db/sql/TestSqlScanManager.cpp <span style="color: grey">(16c29ca)</span></li>
<li>tests/synchronization/TestMasterSlaveSynchronizationJob.cpp <span style="color: grey">(8d1ea51)</span></li>
<li>tests/synchronization/TestUnionJob.cpp <span style="color: grey">(86f4159)</span></li>
<li>utilities/amzdownloader/AmzDownloader.cpp <span style="color: grey">(54106f2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112148/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>