<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111343/">http://git.reviewboard.kde.org/r/111343/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 2nd, 2013, 3:03 p.m. IST, <b>Mark Kretschmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111343/diff/2/?file=166943#file166943line39" style="color: black; font-weight: bold; text-decoration: underline;">src/scriptengine/AmarokCollectionScript.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//deprecate</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the KDE_DEPRECATED macro</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was intending the deprecation notification to be more for the users than us, so they can bug script writers to updating their scripts.</pre>
<br />
<p>- Anmol</p>
<br />
<p>On July 2nd, 2013, 5:53 p.m. IST, Anmol Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Mark Kretschmann.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated July 2, 2013, 5:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Week 2: Added scripting interface for the collection management.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(69a8ff4)</span></li>
<li>src/ScriptManager.h <span style="color: grey">(afaa832)</span></li>
<li>src/ScriptManager.cpp <span style="color: grey">(b7f0a5c)</span></li>
<li>src/core/collections/Collection.h <span style="color: grey">(7e2957d)</span></li>
<li>src/core/collections/QueryMaker.h <span style="color: grey">(92b6a65)</span></li>
<li>src/scriptengine/AmarokCollectionScript.h <span style="color: grey">(5733947)</span></li>
<li>src/scriptengine/AmarokCollectionScript.cpp <span style="color: grey">(3fcda84)</span></li>
<li>src/scriptengine/AmarokEngineScript.h <span style="color: grey">(aa2b112)</span></li>
<li>src/scriptengine/AmarokEngineScript.cpp <span style="color: grey">(5471838)</span></li>
<li>src/scriptengine/AmarokPlaylistScript.h <span style="color: grey">(28f9d7e)</span></li>
<li>src/scriptengine/AmarokPlaylistScript.cpp <span style="color: grey">(2dde634)</span></li>
<li>src/scriptengine/AmarokScriptableServiceScript.cpp <span style="color: grey">(a312671)</span></li>
<li>src/scriptengine/AmarokWindowScript.cpp <span style="color: grey">(c9a65ee)</span></li>
<li>src/scriptengine/MetaTypeExporter.h <span style="color: grey">(031e52b)</span></li>
<li>src/scriptengine/MetaTypeExporter.cpp <span style="color: grey">(5a515a6)</span></li>
<li>src/scriptengine/ScriptingDefines.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/CollectionTypeExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/CollectionTypeExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/MetaTypeExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/MetaTypeExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/QueryMakerExporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/QueryMakerExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111343/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>